1881847 - [meta][Tabs Tray to Compose] Beta to Release tasks

Status: RESOLVED FIXED

(Fenix :: Tabs, task, P2)

Description

[Noah Bond [:007]]

In order to get the Tabs Tray to Compose rewrite into Release, there are a number of tasks we must complete in order to feel confident in letting it ride the trains.

Tasks

Tickets

Bug	Description
Bug 1832618	Convert the remaining UI tests that call into Tabs Tray
Bug 1841140	Bugs found during the Beta bake
Bug 1816746	Add the inactive tabs CFR (this was started here but never finished)
Bug 1887211	Make a new metrics dashboard for the Beta metrics Nightly dashboard
Bug 1815003	Enable the feature flag in Release

Project admin

Investigate why the private tabs page button metric dropped off precipitously
Schedule a checkpoint meeting with Product. (It was Channing previously)
Communicate in Slack when this is being enabled

Dashboards

• Nightly
• Beta
• Release

The bugs fixed by the rewrite can be tracked with the [fixed-by-tabs-tray-compose] whiteboard

Comment 1

[Noah Bond [:007]]

Ideas for future enhancements should be filed in Bug 1881848

Comment 2

[Noah Bond [:007]]

Looking at release versions:

126 would put us at a soft code deadline of ~April 18th, giving us ~6 weeks, ignoring uplifts. I’m also out for ~8 of those work days.

For the work alone, I think that’s theoretically doable. I could foresee a non-zero chance that like we get the work done by 126, but we don’t get a meeting with product to get the green light until after 126 and then we just maybe uplift a PR to change the feature flag to true. This also doesn't factor in any QA lead time.

Having two other engineers would be a huge boon to reaching a release target, as I’m most nervous about the time length for:

• The accidental swipe to delete bug
• Inactive tabs CFR
• Investigation why a metric was (seemingly) over-reporting

Ultimately, with other projects ramping down and needing to onboard people onto this project after I return from vacation, I think we should target 127 and do an official “re-kick-off” of the work.

Comment 3

[Noah Bond [:007]]

I did some investigation into the reporting of the tab page metrics (normalModeTapped, privateModeTapped, and syncedModeTapped) and how privateModeTapped's reporting precipitously dropped after the Tabs Tray rewrite got enabled (the other tab page buttons were unaffected).

The main culprit appears to have, indeed, been over-reporting. The privateModeTapped metric is being fired every time the XML Tabs Tray is opened, rather than when the relevant tab page button was clicked.

Furthering this theory:

• The normal tabs page metric never moved because the metric reporting code path was never hit when opening the Tabs Tray with a selected normal tab.
• The synced tabs page metric never moved because the Tabs Tray is never opened by default to that page.

With all of this established, when the rewrite enters Release, we will actually see an accurate reporting of the privateModeTapped metric.

Comment 4

[Noah Bond [:007]]

I did discover that the tab page metrics are being reported on the button clicks in the Compose rewrite even when the button is for the active tab page. I've opened Bug 1890676 to resolve this.

Comment 5

[Noah Bond [:007]]

I added the metrics dashboards to the top comment

Comment 6

[Noah Bond [:007]]

The bugs fixed by the rewrite can be tracked with the [fixed-by-tabs-tray-compose] whiteboard

Comment 7

[Noah Bond [:007]]

Closing this, as all of the dependent work has been completed and the feature flag has officially been enabled!