1815889 - URLbar results menu for Firefox Suggest and Sponsored Suggest need to be enabled separately

Status: RESOLVED FIXED

(Firefox :: Address Bar, task, P3)

Description

[Adrian Florinescu [:aflorinescu]]

Bug 1815742 and bug 1811870 enable the URLbar results, with the Firefox suggest and Firefox sponsored suggestions missing the functionality, for which :dao confirmed that additional preference needs to be fliped on: browser.urlbar.quicksuggest.blockingEnabled

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 1815889 - Enable quick suggest and best match blocking in Nightly and Earyl Beta. r=adw

This is sort of a straw-man patch. I don't know if we want to retain the ability to disable blocking independently from the result menu being enabled.

Comment 2

[Drew Willcoxon :adw]

I do think we should keep blocking independent of the result menu for now. "Normal" quick suggest results -- the ones that aren't best matches and that come from sponsored partners and Wikipedia -- aren't individually blockable. Now that we have the result menu, it might make sense to just make everything blockable, but in the past Natalie specifically didn't like that idea. I'd like to raise this with a larger group including Nive before we make this change.

Comment 3

[Drew Willcoxon :adw]

I started a Slack thread with Nive here.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/37f71546d283
Enable quick suggest and best match blocking in Nightly and Earyl Beta. r=adw

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/37f71546d283