181649 - Allow users to turn off Favicons in the bookmarks toolbar (at least by hidden pref)

Status: RESOLVED FIXED

(Camino Graveyard :: Toolbars & Menus, enhancement)

Description

[Will Cosgrove]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X; en-US; rv:1.0.1) Gecko/20021122 Chimera/0.6+
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X; en-US; rv:1.0.1) Gecko/20021122 Chimera/0.6+

IMHO, the favicons look like **** in the toolbar bookmarks area.  Most sites
have **** favicons and Chimera looks more polished with the favicons turned
off in that region.  I would love a pref to allow users to turn them off for all
areas but the location text field.

Reproducible: Always

Steps to Reproduce:
1.load Chimera .6+ with bookmarks in the toolbar bookmarks area with favicons

Actual Results:  
the favicons load and look bad. =)

Expected Results:  
should have a pref to turn them off, for the love of clean UI.

none

Comment 1

[Stephane Moureau]

Perhaps it should be handled like a normal toolbar, even if it's not one
internally, via a Control menu: text+icon, text or icon and Remove Item.
It would be less confusing.
See Bug 181954

Comment 2

[Greg K.]

Will, you can disable favicons entirely by adding the line,

   user_pref("browser.chrome.favicons", true);

to your user.js file. Is that sufficient?

Comment 3

[Greg K.]

(er, make that false rather than true.)

Comment 4

[Will Cosgrove]

Ok, that works the way I want.  But it should be listed in the prefs window so
"normal" people can turn it on and off.

Comment 5

[Simon Fraser [no longer active]]

Taking

Comment 6

[Daniel Andrews]

Is it possible to take this one step further, and disable ALL icons in the
toolbar?  It was brought to my attention by someone I was getting to try out
Camino that this was one of the only apps he used that had icons you could not
disable in the toolbar, and he's got a point (albeit a petty one).

In other words, maybe just a tiny little arrow like Safari or FF have for
folders, and no icon at all for regular bookmarks?

This would be a cool little feature that could be imbedded under the hood perhaps.

Comment 7

[Allan]

(In reply to comment #6)
> Is it possible to take this one step further, and disable ALL icons in the
> toolbar? 

Absolutely gets my vote. I have a tiny screen and every pixel counts. Safari is
better at this, although I guess you'd need a highight on mouseover as they do.

Comment 8

[Wevah (Nate Weaver)]

Personally, I don't think there are enough users that want favicons off to
warrant a GUI for the preference.

Comment 9

[Samuel Sidler (old account; do not CC)]

A GUI pref seems like overkill to me. It can be done in user.js. If anyone wants
it in a pref, pref panels aren't too hard to make and can incorporate other
appearance features people are asking for.

WONTFIXing.

Comment 10

[L. H.]

*** Bug 288902 has been marked as a duplicate of this bug. ***

Comment 11

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

*** Bug 298771 has been marked as a duplicate of this bug. ***

Comment 12

[Simon Fraser [no longer active]]

Reopening to ensure that the prefsjs prefs work (which they don't).

Comment 13

[Simon Fraser [no longer active]]

Attachment: Patch to make "browser.chrome.favicons" pref work

This patch fixes support for the "browser.chrome.favicons" pref, so that
turning it off disables all the site-based favicons. We'll still show the
special icons for local files, history and bookmarks.

Comment 14

[Simon Fraser [no longer active]]

Fixed on trunk and branch.