1816613 - Select All didn't select the emails in the current folder, but selected all the emails in the following folders in Thunderbird 111.0a1

Status: RESOLVED WORKSFORME

(Thunderbird :: Mail Window Front End, defect)

Description

[Matt Fagnani]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:109.0) Gecko/20100101 Firefox/111.0

Steps to reproduce:

I used Thunderbird 111.0a1 (2022-1-20) to (2022-2-13) on Wayland in Plasma 5.26.5 in a Fedora 37 KDE Plasma installation. I pressed ctrl+a to select all emails in the folders of an IMAP account or Local Folders. Alternatively, I selected Edit menu in the menu bar then Select > All. Then, I selected different folders.

Actual results:

Using Select All didn't select any of the emails in the current folder immediately. Left-clicking on an email in the first folder after selecting all showed all emails as being selected. Using Select All again removed the selection from all the emails in the folder. After using Select All, all the emails were selected in the following folders that I changed to. All the emails remained selected in those folders after left-clicking on emails which used to remove the selection of all emails. This problem didn't happen with 111.0a1 (2023-1-18) and earlier. I guess the problem is related to the interface changes which were merged 2023-1-19 https://hg.mozilla.org/comm-central/pushloghtml?fromchange=76f62fd3a78092592457e19dbc6e59f87c4f084d&tochange=5abcc1359eb7d4122f958a823e29b43de5f60b2e as described at https://thunderbird.topicbox.com/groups/daily/T7df1556699d655bb/please-read-thunderbird-supernova-alpha-release I waited until February 14 to report this problem as requested on that page.

Expected results:

Using Select All should have selected all the emails in the current folder immediately and not after left-clicking on one email in it. The emails in the following folders I went to shouldn't have all been selected, and clicking on one of those emails should've removed the selection of all of them.

Comment 1

[Matt Fagnani]

Starting with 111.0a1 2023-1-19, using Select All didn't select any of the emails in the current folder immediately, and left-clicking on an email in the first folder after selecting all showed all emails as being selected. However, the following folders I clicked on didn't have all their emails selected with 111.0a1 2023-1-19. The folders in the folder list were all selected after using Select All with 111.0a1 2023-1-19. I bisected the initial problem that using Select All didn't select any of the emails in the current folder immediately, and left-clicking on an email in the first folder after selecting all showed all emails as being selected with mozregression --app thunderbird --good 2023-1-18 --bad 2023-1-19 --persist /tmp/mozregression -p ~/.thunderbird/9hcim5o9.default --profile-persistence reuse

The first bad revision was the interface changes with 282 merge changesets on 2023-1-19 that I guessed were involved.
2:14.95 INFO: Narrowed integration regression window from [76f62fd3, 45322ce6] (3 builds) to [76f62fd3, 5abcc135] (2 builds) (~1 steps left)
2:14.95 INFO: No more integration revisions, bisection finished.
2:14.95 INFO: Last good revision: 76f62fd3a78092592457e19dbc6e59f87c4f084d
2:14.95 INFO: First bad revision: 5abcc1359eb7d4122f958a823e29b43de5f60b2e
2:14.95 INFO: Pushlog:
https://hg.mozilla.org/comm-central/pushloghtml?fromchange=76f62fd3a78092592457e19dbc6e59f87c4f084d&tochange=5abcc1359eb7d4122f958a823e29b43de5f60b2e

I bisected the problem that after using Select All, all the emails were selected in the following folders that I changed to with mozregression --app thunderbird --good 2023-1-19 --bad 2023-2-13 --persist /tmp/mozregression -p ~/.thunderbird/9hcim5o9.default --profile-persistence reuse
The final pushlog had 4 changes. The most likely change of those to be involved looked to be https://hg.mozilla.org/comm-central/rev/612a67daacf7cf1f1e0dac14bb400b339607b2e9 for Bug 1812531 - Make folder tree mode headers unselectable.

9:55.94 INFO: Narrowed integration regression window from [fc998bac, 8d9e21a3] (3 builds) to [32a5dd2f, 8d9e21a3] (2 builds) (~1 steps left)
9:55.94 INFO: No more integration revisions, bisection finished.
9:55.94 INFO: Last good revision: 32a5dd2fa923c7854e2dc9a71d54f78e59075520
9:55.94 INFO: First bad revision: 8d9e21a32fc7c3882283268e0dc799b6fa6c7c82
9:55.94 INFO: Pushlog:
https://hg.mozilla.org/comm-central/pushloghtml?fromchange=32a5dd2fa923c7854e2dc9a71d54f78e59075520&tochange=8d9e21a32fc7c3882283268e0dc799b6fa6c7c82

Comment 2

[Magnus Melin [:mkmelin]]

Ctrl+A works wrongly yes. It selects the text of the UI in the list. It should do message selections.

Comment 3

[Matt Fagnani]

I see. Thanks. Using Select All in 112.0a1 (2023-02-15) immediately showed all the messages selected in grey when I hadn't clicked on an email in a list, and clicking on an email removed their selection. Using Select All after clicking on an email in a list showed all the emails in the list selected in blue. The emails in the folders I clicked on after using Select All weren't all selected as I reported. I bisected to try to find the change that improved this problem with mozregression --app thunderbird --good 2023-2-15 --bad 2023-2-13 --find-fix --persist /tmp/mozregression -p ~/.thunderbird/9hcim5o9.default --profile-persistence reuse

There was one bisection step that didn't show any selections when I used Select All which I marked as bad, and I'm not sure if that was correct.
The pushlog had 11 changesets so I'm not sure which improved this problem.
16:16.38 INFO: Narrowed integration fix window from [283b4fff, 9f0f4f8a] (3 builds) to [7f9bd419, 9f0f4f8a] (2 builds) (~1 steps left)
16:16.38 INFO: No more integration revisions, bisection finished.
16:16.38 INFO: First good revision: 9f0f4f8a4a7b187558e96931d9d9956e8b939d0e
16:16.38 INFO: Last bad revision: 7f9bd4193c5bf898751ca219e384f6decebbcca1
16:16.38 INFO: Pushlog:
https://hg.mozilla.org/comm-central/pushloghtml?fromchange=7f9bd4193c5bf898751ca219e384f6decebbcca1&tochange=9f0f4f8a4a7b187558e96931d9d9956e8b939d0e

Comment 4

[Thomas D. (:thomas8)]

Wfm on 112.0a1 (2023-02-16) (64-bit), Win 10.
Iiuc, reporter (Matt) also reports wfm in comment 3 for Linux.
I'll file some remaining nits.

This looks very similar to bug 1813959, almost duplicate.