1821630 - misplaced system windows buttons to the right - macOS

Status: RESOLVED FIXED

(Thunderbird :: Toolbars and Tabs, defect)

Description

[Nicolas Mandil (:NicolasWeb)]

Attachment: TB misplaced to the right system windows buttons - macOS.jpeg

Actual results :
Since 112a1 build 20230309233507, the system windows buttons on macOS are misplaced to the right.

Expected results:
These windows system button should be placed to the left of the window

Regression: Okay in 102. Was okay with yesterday previous EN-US Dialy build

Comment 1

[Magnus Melin [:mkmelin]]

Probably from modern flexbox (see bug 1821304)?

Comment 2

[Richard Marti (:Paenglab)]

Regression from bug 1820744. It exchanged the -moz-box-ordinal-group: 0; into order: -1; instead of order: 0;.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

But that's the right thing to do, order: 0 is the initial value.

Comment 4

[Richard Marti (:Paenglab)]

I tried it with 0 in inspector and it fixed the issue. Maybe it would be better to remove it to use the initial value.

Comment 5

[Richard Marti (:Paenglab)]

Attachment: Bug 1821630 - Don't use row-reverse for the unifiedToolbarContainer on macOS. r=aleca

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/70c3859547b3
Don't use row-reverse for the unifiedToolbarContainer on macOS. r=aleca

Comment 7

[Kai Engert (:KaiE:)]

We'd like to backout bug 1820744 from comm-beta 112.
Because this change here was made on top of the change from bug 1820744, I suggest to backout this one from 112, too.
Does anyone disagree?

Comment 8

[Kai Engert (:KaiE:)]

Wayne gave approval on Matrix. I'll push the backout shortly.

Should anyone request to keep this on beta, we'll have to reland with merging (if that's even possible).

Comment 9

[Kai Engert (:KaiE:)]

backed out from 112, keeping for 113
https://hg.mozilla.org/releases/comm-beta/rev/514e8d02facd2404d11b15978a4638be4ccda281