Closed Bug 1826441 Opened 2 years ago Closed 1 year ago

With imap delete model "just mark as deleted", context menu and toolbar buttons still say Delete, not Undelete

Categories

(Thunderbird :: Folder and Message Lists, defect)

Product:
Thunderbird
Component:
Folder and Message Lists
Type:
defect

Tracking

(thunderbird_esr102 unaffected)

Status:
RESOLVED FIXED
Milestone:
115 Branch
Tracking Flags:
Tracking Status
thunderbird_esr102 --- unaffected

People

(Reporter: gds, Assigned: darktrojan)

References

(Blocks 1 open bug)

Details

(Keywords: regression, ux-mode-error, Whiteboard: [Supernova3p][Fixed in bug 1731837, bug 1824018])

This may be related to the RESOLVED bug 1816041, not sure.
If I right click on a crossed out message that has been marked deleted, the menu only contains "Delete Message". Previously, e.g., <=102, the right click menu item said "Undelete Message".
However, clicking "Delete Message" on the already marked as deleted message does seem to remove the imap deleted flag and removes the strike-though on the message.

Note: in bug 1816041 there is mention of changing the label on the delete button to "restore" for marked deleted messages, but that doesn't seem to be implemented yet.

Yes, toolbar button has the same issue.

Keywords: regression
Summary: With imap delete model "just mark as deleted", "Undelete message" no longer appears for deleted messages on right-click → With imap delete model "just mark as deleted", context menu and toolbar buttons still say Delete, not Undelete
Whiteboard: [Supernova]

Confirming for 113.0a1 (2023-04-03) (64-bit), Win10.
Couldn't check the Edit menu due to related bug 1731837, which we should certainly fix now, too.

STR

  • From account settings of IMAP account, set:
    ≡ > Account Settings > YourAccount > Server Settings > When I delete a message: Just mark it as deleted
  • Delete a msg from the account
  • Look at message header buttons and context menu wrt delete command

Actual

  • All visible instances of cmd_delete items do not get their labels updated, so still showing Delete instead of Undelete
    • Context menu Delete
    • message header pane Delete button
    • unified toolbar Delete button
    • Couldn't check the Edit menu due to related bug 1731837, which we should certainly fix now, too.

Expected

  • When only message(s) marked as deleted are selected, all visible instances of cmd_delete items should get their labels updated and show Undelete (on toolbars) or Undelete message (in menus).
Blocks: tb-new-3pane
Keywords: ux-mode-error
See Also: → 1731837
Whiteboard: [Supernova] → [Supernova3p]

Looking at this and many other Delete UI things.

Assignee: nobody → geoff
Status: NEW → ASSIGNED

Fixed by bug 1731837 and bug 1824018.

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Whiteboard: [Supernova3p] → [Supernova3p][Fixed in bug 1731837, bug 1824018]
Target Milestone: --- → 115 Branch

I'm now seeing "undelete messages" on the context popup for the crossed out message(s) -- so that's fixed. But the message toolbar still shows the label "Delete" which can also do the "undelete", I think.

You need to log in before you can comment on or make changes to this bug.