1836217 - Migrate remaining spaces and remove old calendar/task tab toolbars

Status: RESOLVED FIXED

(Thunderbird :: Toolbars and Tabs, task)

Description

[Martin Giger [:freaktechnik]]

• Migrate the calendar/task toolbar contents to the unified toolbar
• Migrate the remaining spaces (address book, chat, settings) by adding just the available global items to the default set
• Remove the calendar/tasks toolbars

Comment 1

[Martin Giger [:freaktechnik]]

Attachment: Bug 1836217 - Migrate calendar and tasks toolbars to unified toolbar. r=#thunderbird-reviewers

Comment 2

[Martin Giger [:freaktechnik]]

Attachment: Bug 1836217 - Migrate remaining toolbars to unified toolbar. r=#thunderbird-reviewers

Remaining toolbars just get the items from the tab bar and menubar. Once we migrated all spaces we can clear the state of the old XUL toolbars for the tab bar and menubar.

Depends on D179652

Comment 3

[Martin Giger [:freaktechnik]]

Attachment: Bug 1836217 - Remove calendar/tasks toolbar. r=#thunderbird-front-end-reviewers

Depends on D179653

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/c732fa6a738c
Migrate calendar and tasks toolbars to unified toolbar. r=aleca
https://hg.mozilla.org/comm-central/rev/18477be0a5fc
Migrate remaining toolbars to unified toolbar. r=aleca
https://hg.mozilla.org/comm-central/rev/f71b3f958e5c
Remove calendar/tasks toolbar. r=aleca

Comment 5

[Martin Giger [:freaktechnik]]

Comment on attachment 9336959 [details]
Bug 1836217 - Remove calendar/tasks toolbar. r=#thunderbird-front-end-reviewers

Only writing one approval request in this bug for the stack of three patches. Happy to copy it over if that's necessary.

[Approval Request Comment]
Regression caused by (bug #):
User impact if declined: Confusing UI parts left from the mail toolbar, incomplete migration of the contents from some of the mailtoolbar areas (only migrated in mail space).
Testing completed (on c-c, etc.): Lots of manual testing during review to test various upgrade paths, some automated tests for the upgrade logic.
Risk to taking this patch (and alternatives if risky): This could lose a user's toolbar configuration, but I think we are treating that as non-irrecoverable data, since you can still customize your toolbar to restore the layout you like.

Comment 6

[Wayne Mery (:wsmwk)]

Comment on attachment 9336957 [details]
Bug 1836217 - Migrate calendar and tasks toolbars to unified toolbar. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta

Comment 7

[Wayne Mery (:wsmwk)]

Comment on attachment 9336958 [details]
Bug 1836217 - Migrate remaining toolbars to unified toolbar. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta

Comment 8

[Wayne Mery (:wsmwk)]

Comment on attachment 9336959 [details]
Bug 1836217 - Remove calendar/tasks toolbar. r=#thunderbird-front-end-reviewers

[Triage Comment]
Approved for beta

Comment 9

[Rob Lemley [:rjl]]

Thunderbird 115.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/bf8ebdf8e5ff
https://hg.mozilla.org/releases/comm-beta/rev/15b13e54b39e
https://hg.mozilla.org/releases/comm-beta/rev/a7838176f4e5