1837088 - Only migrate mail toolbar if it has not been customized

Status: RESOLVED FIXED

(Thunderbird :: Toolbars and Tabs, task, P1)

Description

[Martin Giger [:freaktechnik]]

We want to give more users a chance to re-learn the Thunderbird Supernova UI patterns. We feel confident enough to achieve this by migrating the mail toolbars of fewer users. Specifically, we intend to not migrate the mail toolbar contents that match the default toolbar for users in 102, because all those actions are contextually exposed in the Mail space, and we want to use the occasion to invite users to not rely on the out-of-context experience of reaching for toolbar buttons when needing to interact with messages or folders.

In more technical terms:
If the following conditions are true, do not migrate contents:

• Mail toolbar contents match default contents for the current configuration (OS, extensions)
  • AND Menubar contents match default contents for the current configuration
  • AND Tabbar contents match default contents for the current configuration
• OR There are no states saved for any of the three toolbars (mail, menubar, tabbar)

When we skip migration for these reasons we still clean up the XUL store of the mail toolbar

Comment 1

[Martin Giger [:freaktechnik]]

Attachment: Bug 1837088 - Don't migrate mail toolbar if old toolbar contents are just the default set. r=#thunderbird-front-end-reviewers

Depends on D179655

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/60744b4797f4
Don't migrate mail toolbar if old toolbar contents are just the default set. r=aleca

Comment 3

[Martin Giger [:freaktechnik]]

Comment on attachment 9337779 [details]
Bug 1837088 - Don't migrate mail toolbar if old toolbar contents are just the default set. r=#thunderbird-front-end-reviewers

[Approval Request Comment]
Regression caused by (bug #):
User impact if declined: We will migrate the old toolbar contents for more users than we think is necessary (see also description of bug for rationale)
Testing completed (on c-c, etc.): Automated tests, manual upgrade testing during review.
Risk to taking this patch (and alternatives if risky): Low risk, only reduces how many people have their mail toolbar contents migrated.

Builds on top of bug 1824290 and bug 1836217.

Comment 4

[Wayne Mery (:wsmwk)]

Comment on attachment 9337779 [details]
Bug 1837088 - Don't migrate mail toolbar if old toolbar contents are just the default set. r=#thunderbird-front-end-reviewers

[Triage Comment]
Approved for beta

Comment 5

[Rob Lemley [:rjl]]

Thunderbird 115.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/ea4bcc421dd6