1838341 - Caldav subscription modal doesn't use all space available

Status: RESOLVED FIXED

(Calendar :: Dialogs, defect)

Description

[Jérémie Parisel]

Attachment: 2023-06-14_00-41.png

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:109.0) Gecko/20100101 Firefox/114.0

Steps to reproduce:

Try to subscribe to an calendar from a caldav server where more than 8 calendars available.

Actual results:

Only the first 8 calendars were shown.
The others were hidden with an invisible scrollbar. I had to guess they existed.

Expected results:

All calendar should have been visible or at least the scrollbar should be visible

Also, there should be a button or checkbox to unselect all calendars in the Caldav wizard (see https://bugzilla.mozilla.org/show_bug.cgi?id=1733959)

And my password shouldn't be asked twice if a try to add 2 different calendar from the same server and that I saved my password (see https://bugzilla.mozilla.org/show_bug.cgi?id=1790581)

Comment 1

[Magnus Melin [:mkmelin] (away until Aug 10)]

Attachment: Bug 1838341 - Caldav subscription dialog list of calendars should fill out the dialog. r=#thunderbird-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/c389718fbb6e
Caldav subscription dialog list of calendars should fill out the dialog. r=john.bieling

Comment 3

[Magnus Melin [:mkmelin] (away until Aug 10)]

Comment on attachment 9338993 [details]
Bug 1838341 - Caldav subscription dialog list of calendars should fill out the dialog. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #): modern flexbox
User impact if declined: bad UI
Testing completed (on c-c, etc.): c-c
Risk to taking this patch (and alternatives if risky): very safe

Comment 4

[Wayne Mery (:wsmwk)]

Comment on attachment 9338993 [details]
Bug 1838341 - Caldav subscription dialog list of calendars should fill out the dialog. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta

Comment 5

[Daniel Darnell [:dandarnell]]

Thunderbird 115.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/4acf96094116