Use PGO-based orderfile
Categories
(Firefox Build System :: General, task)
Tracking
(firefox123 fixed)
| Tracking | Status | |
|---|---|---|
| firefox123 | --- | fixed |
People
(Reporter: sergesanspaille, Assigned: sergesanspaille)
References
Details
Attachments
(2 files)
With clang 17 a new kind of pgo-based instrumentation will be available (called temporal instrumentation). It can be used to derive an orderfile.
|
Assignee | |
Comment 1•11 months ago
|
||
|
|
Assignee | |
Comment 2•11 months ago
|
||
Depends on D181749
Pushed by sguelton@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0f25efce3714 Detect compiler support for temporal instrumentation r=glandium
|
||
Comment 4•11 months ago
|
||
| bugherder | ||
|
||
Comment 5•11 months ago
|
||
Backed out for causing build bustages, requested by glandium
|
|
||
Updated•11 months ago
|
|
|
||
Comment 6•11 months ago
|
||
Backout merged to central: https://hg.mozilla.org/mozilla-central/rev/243ab04b37e3
Pushed by sguelton@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9f805dc435b5 Detect compiler support for temporal instrumentation r=glandium
|
||
Comment 8•10 months ago
|
||
| bugherder | ||
|
||
Updated•10 months ago
|
Pushed by sguelton@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3dcccc40be04 Use PGO-based orderfile when possible r=glandium
|
|
||
Comment 10•10 months ago
|
||
| bugherder | ||
|
||
Comment 11•10 months ago
|
||
Backed out for causing shippable build bustage
Backout link: https://hg.mozilla.org/integration/autoland/rev/09025d4def551715279580cdb8fab353287aae62
|
|
||
Updated•10 months ago
|
|
|
||
Comment 12•10 months ago
|
||
Backout merged to central: https://hg.mozilla.org/mozilla-central/rev/09025d4def551715279580cdb8fab353287aae62
|
|
Assignee | |
Comment 13•10 months ago
|
||
Error due to an invalid profdata file that slipped unchecked through the run step. Proposed detection in https://bugzilla.mozilla.org/show_bug.cgi?id=1844769
|
|
||
Comment 14•10 months ago
|
||
Backed out as requested by glandium for causing shippable build bustages.
|
||
Comment 15•5 months ago
|
||
Pushed by sguelton@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/96f4aa903123 Use PGO-based orderfile when possible r=glandium
|
|
||
Comment 16•5 months ago
|
||
Backed out for causing bpgo bustages
Backout link: https://hg.mozilla.org/integration/autoland/rev/fe233790fb9b2ded19de2d3c57ed746be85dc632
Failure log -> PROCESS-CRASH | None [@ nsXPTMethodInfo::ParamCount] | Profile initialization
|
|
Assignee | |
Comment 17•5 months ago
|
||
How strange, we fixed that issue through https://bugzilla.mozilla.org/show_bug.cgi?id=1867863...
|
|
Assignee | |
Comment 18•5 months ago
|
||
Bug spot, thanks to Yannis: there were other naked function to flag correctly
|
|
||
Comment 19•5 months ago
|
||
Pushed by sguelton@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ba2e5b5e061b Use PGO-based orderfile when possible r=glandium
|
||
Comment 20•5 months ago
|
||
| bugherder | ||
|
||
Updated•4 months ago
|
|
||
Comment 22•3 months ago
|
||
This one breaks GCC PGO builds - I expect reorder files can't be used with GCC:
26:26.09 DEBUG: Executing: `/usr/bin/llvm-profdata order /raid/CVS/firefox/firefox-123.0/objdir/instrumented/merged.profdata -o /raid/CVS/firefox/firefox-123.0/objdir/orderfile.txt`
26:26.09 DEBUG: The command returned non-zero exit status 1.
26:26.09 DEBUG: Its error output was:
26:26.09 DEBUG: | error: /raid/CVS/firefox/firefox-123.0/objdir/instrumented/merged.profdata: No such file or directory
26:26.09 ERROR: Command `/usr/bin/llvm-profdata order /raid/CVS/firefox/firefox-123.0/objdir/instrumented/merged.profdata -o /raid/CVS/firefox/firefox-123.0/objdir/orderfile.txt` failed with exit status 1.
Looks like reorder files are generated regardless of used compiler.
Description
•