1840139 - Create error component

Status: RESOLVED FIXED

(Firefox :: Shopping, task, P2)

Description

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

When the backend is unreachable, we want to show an error component at the top of the sidebar.

There's a button in the designs but it's not clear how often we want users to be able to attempt to ping the backend if it's struggling (TBD)

Figma link: https://www.figma.com/file/Wu4kaHSfKSQnzkym7qek3R/Shopping-Experience-MVP?type=design&node-id=1-265&mode=design&t=ju5kpYU0FsL9ZVXf-0

See also a11y annotations in figma: https://www.figma.com/file/Wu4kaHSfKSQnzkym7qek3R/Shopping-Experience-MVP?type=design&node-id=1-265&mode=design&t=s4GFkPNxsyXbFQRZ-0

Comment 1

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Attachment: 6/23 screenshot of figma

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Setting P3 for now, as this is currently unassigned.

Comment 3

[Niklas Baumgardner [:niklas]]

Attachment: Bug 1840139 - Create generic error shopping card. r=#shopping-reviewers

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7ebfd2e7a63a
Create generic error shopping card. r=shopping-reviewers,fluent-reviewers,flod,Gijs

Comment 5

[Noemi Erli[:noemi_erli]]

Backed out changeset 7ebfd2e7a63a (Bug 1840139) for causing failures in browser_unanalyzed_product.js CLOSED TREE

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&selectedTaskRun=BCdb3mfmS92dECRR5TcgTA.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=7ebfd2e7a63a2b5717c24bbbf46199f7186d3172

Log: https://treeherder.mozilla.org/logviewer?job_id=424525104&repo=autoland&lineNumber=10895

Backout: https://hg.mozilla.org/integration/autoland/rev/59074b86bcbdee7c9d73bce56fa472b31fdca631

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/54ff3fcb5561
Create generic error shopping card. r=shopping-reviewers,fluent-reviewers,flod,Gijs

Comment 7

[Natalia Csoregi [:nataliaCs]]

Backed out for causing failures on browser_adjusted_rating.js

• backout: https://hg.mozilla.org/integration/autoland/rev/51fc2dc7c5f9a8c792c0c093dbf86a7350785a10
• push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&selectedTaskRun=W7wZ1akfRl-fhDINi-I_mA.0&revision=54ff3fcb55617bb0efe314ef484a36bf8008f4ab
• failure log: https://treeherder.mozilla.org/logviewer?job_id=424574914&repo=autoland&lineNumber=10497

[task 2023-08-01T21:48:57.379Z] 21:48:57     INFO - TEST-START | browser/components/shopping/tests/browser/browser_adjusted_rating.js
[task 2023-08-01T21:48:57.614Z] 21:48:57     INFO - GECKO(3541) | [Parent 3541: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 7faacf385000 == 6 [pid = 3541] [id = 5]
[task 2023-08-01T21:48:57.616Z] 21:48:57     INFO - GECKO(3541) | [Parent 3541: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 13 (7faad8734f20) [pid = 3541] [serial = 13] [outer = 0]
[task 2023-08-01T21:48:57.618Z] 21:48:57     INFO - GECKO(3541) | [Parent 3541: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 14 (7faad2e9d000) [pid = 3541] [serial = 14] [outer = 7faad8734f20]
[task 2023-08-01T21:48:57.707Z] 21:48:57     INFO - GECKO(3541) | [Parent 3541: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 15 (7fab0515ec00) [pid = 3541] [serial = 15] [outer = 7faad8734f20]
[task 2023-08-01T21:48:57.741Z] 21:48:57     INFO - GECKO(3541) | [Parent 3541, Main Thread] WARNING: Failed to retarget HTML data delivery to the parser thread.: file /builds/worker/checkouts/gecko/parser/html/nsHtml5StreamParser.cpp:1235
[task 2023-08-01T21:48:58.174Z] 21:48:58     INFO - GECKO(3541) | [Parent 3541, Main Thread] WARNING: '!inner', file /builds/worker/checkouts/gecko/dom/ipc/jsactor/JSWindowActorProtocol.cpp:163
[task 2023-08-01T21:48:58.176Z] 21:48:58     INFO - GECKO(3541) | [Parent 3541, Main Thread] WARNING: '!inner', file /builds/worker/checkouts/gecko/dom/ipc/jsactor/JSWindowActorProtocol.cpp:163
[task 2023-08-01T21:48:58.190Z] 21:48:58     INFO - TEST-INFO | started process screentopng
[task 2023-08-01T21:48:58.655Z] 21:48:58     INFO - TEST-INFO | screentopng: exit 0
[task 2023-08-01T21:48:58.655Z] 21:48:58     INFO - Buffered messages logged at 21:48:57
[task 2023-08-01T21:48:58.655Z] 21:48:58     INFO - Entering test bound test_adjusted_rating
[task 2023-08-01T21:48:58.656Z] 21:48:58     INFO - Buffered messages finished
[task 2023-08-01T21:48:58.657Z] 21:48:58     INFO - TEST-UNEXPECTED-FAIL | browser/components/shopping/tests/browser/browser_adjusted_rating.js | Uncaught exception in test bound test_adjusted_rating - at chrome://mochitests/content/browser/browser/components/shopping/tests/browser/browser_adjusted_rating.js:21 - TypeError: can't access property "updateComplete", adjustedRating is null
[task 2023-08-01T21:48:58.657Z] 21:48:58     INFO - Stack trace:
[task 2023-08-01T21:48:58.658Z] 21:48:58     INFO - test_adjusted_rating/<@chrome://mochitests/content/browser/browser/components/shopping/tests/browser/browser_adjusted_rating.js:21:7
[task 2023-08-01T21:48:58.658Z] 21:48:58     INFO - async*withNewTab@resource://testing-common/BrowserTestUtils.sys.mjs:146:22
[task 2023-08-01T21:48:58.658Z] 21:48:58     INFO - async*test_adjusted_rating@chrome://mochitests/content/browser/browser/components/shopping/tests/browser/browser_adjusted_rating.js:7:26
[task 2023-08-01T21:48:58.658Z] 21:48:58     INFO - handleTask@chrome://mochikit/content/browser-test.js:1131:26
[task 2023-08-01T21:48:58.659Z] 21:48:58     INFO - _runTaskBasedTest@chrome://mochikit/content/browser-test.js:1203:18
[task 2023-08-01T21:48:58.659Z] 21:48:58     INFO - Tester_execTest@chrome://mochikit/content/browser-test.js:1345:14
[task 2023-08-01T21:48:58.659Z] 21:48:58     INFO - nextTest/<@chrome://mochikit/content/browser-test.js:1120:14
[task 2023-08-01T21:48:58.659Z] 21:48:58     INFO - SimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1056:13
[task 2023-08-01T21:48:58.659Z] 21:48:58     INFO - Leaving test bound test_adjusted_rating

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d3afebcd350c
Create generic error shopping card. r=shopping-reviewers,fluent-reviewers,flod,Gijs

Comment 9

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/d3afebcd350c

Comment 10

[Rares Doghi, Desktop QA]

Hi @Jared, is there a way for us to trigger this error ?