1841446 - Update the "Not interested" command to disable Pocket suggestions.

Status: VERIFIED FIXED

(Firefox :: Address Bar, task, P1)

Description

[Drew Willcoxon :adw]

The "Not interested" command should disable Pocket suggestions and show a slightly different dismissal-acknowledgment message. See the user feedback signals doc.

Comment 1

[Drew Willcoxon :adw]

Attachment: Bug 1841446 - Update the "Not interested" command to disable Pocket suggestions.

Depends on D182606

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2762ca36c7c5
Update the "Not interested" command to disable Pocket suggestions. r=daisuke,fluent-reviewers,flod

Comment 3

[Drew Willcoxon :adw]

STR for QA:

1. Set browser.urlbar.pocket.featureGate = true to enable Pocket suggestions and browser.urlbar.bestMatch.enabled to enable best match
2. Type "breakfast" and verify a low confidence (non-top-pick) Pocket suggestion appears
3. Click the Feedback button and choose "Don't show this > Not interested" (If the button doesn't appear, try again after bug 1841409 lands)
4. Verify the suggestion is replaced with a "Thanks for your feedback" message with a "Got it" button
5. Click "Got it"
6. Verify the message goes away
7. Type "breakfast" again
8. Verify the suggestion does not appear
9. Type "breakfast casserole" and "breakfast paninis" and verify no Pocket suggestions appear
10. Reset the browser.urlbar.suggest.pocket pref (should become true again)
11. Type "breakfast paninis" and verify a top pick appears
12. Click the Feedback button and choose "Don't show this > Not interested"
13. Repeat steps 4-9

Comment 4

[Drew Willcoxon :adw]

Comment on attachment 9342054 [details]
Bug 1841446 - Update the "Not interested" command to disable Pocket suggestions.

Beta/Release Uplift Approval Request

• User impact if declined: This bug is necessary for the Pocket suggestions feature we intend to ship as an experiment in 116.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Please see STR in previous comment
• List of other uplifts needed: The following bugs must be uplifted first: 1841354, Bug 1841295, Bug 1841553, Bug 1841408, Bug 1841442, Bug 1837097
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Only affects Pocket suggestions, which are disabled by default. Has tests.
• String changes made/needed: None: This patch modifies the Firefox Suggest FTL file, but the file is not localized. It is en-US only.
• Is Android affected?: No

Comment 5

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/2762ca36c7c5

Comment 6

[Carmen Fat [:cfat] - Ecosystem QA]

I have verified this issue on the latest Firefox Nightly 117.0a1 (Build ID: 20230706092222), on Windows 10 x64, macOS 13.4.1, and Ubuntu 20.04 x64.

• The "Cat Cora" Pocket suggestion appears at the bottom of the Urlbar panel (Firefox Suggest section) after typing the complete string (“breakfast”);
• The "Thanks for your feedback. You won't see these suggestions anymore." message with the “Got it” button appears in the suggestion after clicking the “Don't show this > Not interested” option from the “Feedback” menu.
• The message is dismissed after clicking the “Got it” button.
• The "Cat Cora" Pocket suggestion is no longer displayed when typing “breakfast” or "breakfast casserole" keywords.
• The top pick Pocket suggestion is also not displayed when typing the "breakfast paninis" keywords.
• Same behavior as above is happening when disabling the Pocket suggestions via a high confidence result (top pick section).

Comment 7

[Dianna Smith [:diannaS]]

Comment on attachment 9342054 [details]
Bug 1841446 - Update the "Not interested" command to disable Pocket suggestions.

Approved for 116.0b2

Comment 8

[Dianna Smith [:diannaS]]

https://hg.mozilla.org/releases/mozilla-beta/rev/a3dbe5f258d2

Comment 9

[Carmen Fat [:cfat] - Ecosystem QA]

I have verified this issue on the latest Firefox Beta 116.0b2 (Build ID: 20230706193912), on Windows 10 x64, macOS 13.4.1, and Ubuntu 20.04 x64.

• The "Cat Cora" Pocket suggestion appears at the bottom of the Urlbar panel (Firefox Suggest section) after typing the complete string (“breakfast”);
• The "Thanks for your feedback. You won't see these suggestions anymore." message with the “Got it” button appears in the suggestion after clicking the “Don't show this > Not interested” option from the “Feedback” menu.
• The message is dismissed after clicking the “Got it” button.
• The "Cat Cora" Pocket suggestion is no longer displayed when typing “breakfast” or "breakfast casserole" keywords.
• The top pick Pocket suggestion is also not displayed when typing the "breakfast paninis" keywords.
• Same behavior as above is happening when disabling the Pocket suggestions via a high confidence result (top pick section).