Keyboard shortcut wrong on macOS when running TB in Dutch
Categories
(Thunderbird :: Mail Window Front End, defect)
Tracking
(thunderbird_esr115 fixed, thunderbird119 fixed)
People
(Reporter: ringo, Assigned: aleca)
References
Details
Attachments
(1 file)
48 bytes,
text/x-phabricator-request
|
wsmwk
:
approval-comm-beta+
wsmwk
:
approval-comm-esr115+
|
Details | Review |
Steps to reproduce:
Download 115 release version from the Dutch landing page: https://www.thunderbird.net/nl/
Started it, worked a bit, then pressed Command+Q to quit Thunderbird.
Actual results:
After pressing Command+Q to quit Thunderbird, nothing happened. When running TB with the Dutch language pack, the keyboard shortcut to Quit TB on macOS became Cmd-F.
Expected results:
Independent of the UI language, there are a set of keyboard shortcuts which should remain the same for all macOS apps.
- To quit an app, Command-Q is the default shortcut.
- Cut, copy, paste are respectively Command+X, Command+C and Command+V
Apple doc in various languages all documenting Command+Q to quit an app:
Comment 1•2 years ago
|
||
Reproduces for others?
Also on Linux, Ctrl-Q does nothing, Ctrl-F closes Thunderbird.
KDE neon 5.27 x86_64, Thunderbird 115.0 nl, Build-ID 20230711125218
Updated•2 years ago
|
Comment 4•2 years ago
|
||
If it's supposed to be Ctrl-Q/Command-Q regardless of language, then this is not a localization bug; it's a UX bug and the ability to translate it should be removed.
Alex, could you have someone look at this please?
Comment 5•2 years ago
|
||
In Firefox we normally keep them localizable, in case the key is not available in the layout. But we also check for translations that are not justified.
Comment 6•2 years ago
|
||
That makes sense, so now I have to question where the breakdown occurred. Because looking at https://transvision.flod.org/string/?entity=browser/browser/browserSets.ftl:quit-app-shortcut.key&repo=gecko_strings, I only see "Q"s.
Looking at https://searchfox.org/mozilla-central/rev/a7e33b7f61e7729e2b1051d2a7a27799f11a5de6/browser/locales/en-US/browser/browserSets.ftl#203, there's a block comment stating that the shortcuts following it are for the macOS global menu. Is that what's needed here?
Comment 7•2 years ago
|
||
Not sure I understand: you're looking at browser, but this breakage is in Thunderbird's code (likely the string I pointed to).
Comment 8•2 years ago
|
||
Sorry, I kind of jumped around a bit.
I look at Firefox's Quit shortcut, and I see a "Q" for Dutch. As you said, it is a translatable string so I'm thinking that there is a clue (or a comment) left for translators in Firefox's Fluent file that Thunderbird is missing. That's how I found the block comment in browserSets.ftl that talks about the macOS global menu.
Assignee | ||
Comment 9•2 years ago
|
||
Our shortcut comes from here: https://searchfox.org/comm-central/rev/570e29bd6159a910d43fc0e4f8fedfffb9357f6a/mail/locales/en-US/messenger/menubar.ftl#82
indeed someone translated this in Pontoon to f
, for whatever reason: https://pontoon.mozilla.org/nl/thunderbird/mail/messenger/menubar.ftl/?search=quit-app-shortcut&string=261545
Comment 10•2 years ago
|
||
(In reply to Alessandro Castellani [:aleca] from comment #9)
indeed someone translated this in Pontoon to
f
, for whatever reason:
Because the difference between a shortcut and an access key is not an easy concept to understand, and the label in Dutch is Afsluiten
.
Updated•1 years ago
|
Updated•1 years ago
|
Comment 13•1 years ago
|
||
Alex, we need a localization note added to the code, correct?
And then kick this back to localizers?
Assignee | ||
Comment 14•1 years ago
|
||
Updated•1 years ago
|
Assignee | ||
Comment 15•1 years ago
|
||
The string has been fixed in Pontoon.
I created a simple comment to prevent this.
Assignee | ||
Updated•1 years ago
|
Assignee | ||
Updated•1 years ago
|
Updated•1 years ago
|
Comment 16•1 years ago
|
||
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/68d66daf4923
Add a localization note to prevent updating the macOS quit shortcut. r=leftmostcat
Comment 17•1 years ago
|
||
Comment on attachment 9355356 [details]
Bug 1843023 - Add a localization note to prevent updating the macOS quit shortcut. r=#thunderbird-reviewers
[Triage Comment]
Approved for beta
Comment 20•1 years ago
|
||
Comment on attachment 9355356 [details]
Bug 1843023 - Add a localization note to prevent updating the macOS quit shortcut. r=#thunderbird-reviewers
[Triage Comment]
Approved for esr115
Comment 21•1 years ago
|
||
bugherder uplift |
Thunderbird 119.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/f7af1203911a
Comment 23•1 years ago
|
||
(In reply to Wayne Mery (:wsmwk) from comment #20)
Comment on attachment 9355356 [details]
Bug 1843023 - Add a localization note to prevent updating the macOS quit shortcut. r=#thunderbird-reviewers[Triage Comment]
Approved for esr115
Note to fix for c-esr115, repin l10n-changesets.json.
Comment 24•1 year ago
|
||
bugherder uplift |
Description
•