1843308 - Take into account openers in BounceTrackingState::OnStartNavigation

Status: RESOLVED FIXED

(Core :: Privacy: Anti-Tracking, task, P2)

Description

[Paul Zühlcke [:pbz]]

When a navigation is started as the result of opening a new tab or window, e.g. by link click or by window.open call we need to ensure the BounceTrackingRecord is still properly tracked across opener relationship.
See https://github.com/privacycg/nav-tracking-mitigations/issues/50 for details.

Note: This includes the case where the current navigation was initiated by another navigable, e.g. when opening a link in a new tab. In this case, sourceDocument is set to the opener Document, and the new bounce tracking record has its initial host set to the opener host. This ensures that trackers opened in new tabs are detected as distinct from the initial host in the new bounce tracking record.

Comment 1

[Paul Zühlcke [:pbz]]

Attachment: Bug 1843308 - Add tests for bounce tracking using popups and new tabs. r=bvandersloot!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b29ebdf1439e
Add tests for bounce tracking using popups and new tabs. r=bvandersloot,anti-tracking-reviewers

Comment 3

[Sandor Molnar[:smolnar]]

Backed out for causing AddressSanitizer @ xpcom/base/nsISupportsImpl.cpp & bc failures @ toolkit/components/antitracking/bouncetrackingprotection/test/browser/<...>

Backout link: https://hg.mozilla.org/integration/autoland/rev/c80113ab4162029cc65655161b3466ba25380dea

Push with failures

Failure log -> SUMMARY: AddressSanitizer: access-violation /builds/worker/checkouts/gecko/xpcom/base/nsISupportsImpl.cpp:41 in nsAutoOwningThread::AssertCurrentThreadOwnsMe

Failure log -> TEST-UNEXPECTED-FAIL | toolkit/components/antitracking/bouncetrackingprotection/test/browser/browser_bouncetracking_stateful_cookies.js | Test timed out

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4c476414499a
Add tests for bounce tracking using popups and new tabs. r=bvandersloot,anti-tracking-reviewers

Comment 5

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4222b068c5cf
Backed out 15 changesets (bug 1843308, bug 1889444, bug 1888504, bug 1890546, bug 1888500, bug 1848406, bug 1890782) for causing bustage on BounceTrackingProtection.h CLOSED TREE

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/242f8153a442
Add tests for bounce tracking using popups and new tabs. r=bvandersloot,anti-tracking-reviewers

Comment 7

[Aron Cseh]

https://hg.mozilla.org/mozilla-central/rev/242f8153a442