1843804 - Inconsistent bar heights with Supernova

Status: VERIFIED FIXED

(Thunderbird :: Toolbars and Tabs, defect, P3)

Description

[Wayne Mery (:wsmwk)]

+++ This bug was initially created as a clone of Bug #1837594 +++

I see this with 116 beta, and I assume it also is relevant to 115.

1. The height of QFB, unified toolbar, message list header, tabs is inconsistent. Unified and FQB are the same size, and larger than the other two (message list header is the least tall). The result is somewhat visually unappealing.

2. Also, unified tool bar appears to be taller than it really is, because there is more whitespace above and below search bar field (see green) which is because the search bar field is not as tall (see red) - at least in comparison to the QFB. Even though the text height of the two fields is the same. (bug 1830248 comment 3)

3. Side note, which we already know, is we are getting many user reports about the height/vertical space used used by the Unified tool bar - bug 1830248. Currently bug 1830248 does not capture the amount of user reports we are seeing - https://support.mozilla.org/en-US/questions/1418113 is an example. (I'd also like to see both QFB and unified toolbar have less height)

Comment 1

[Wayne Mery (:wsmwk)]

Attachment: tb116-bar-heights.png

Comment 2

[[:Aureliano Buendía]]

Attachment: screenshot.png

I agree with Wayne.
I also notice that, in Relaxed mode, the caption bar of the window is very large, at least in windows 11

Comment 3

[Wayne Mery (:wsmwk)]

p.s screen shots on Mac, density=compact, Mac OS set to largest text size.

I'll check a Windows system which should have default OS settings.

Comment 4

[Alessandro Castellani [:aleca]]

I'll take this and polish sizes a bit

Comment 5

[Alessandro Castellani [:aleca]]

Attachment: Bug 1843804 - Polish and solidify the various toolbars desnity variations in the about3Pane. r=#thunderbird-front-end-reviewers

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/6fc6c72cb657
Polish and solidify the various toolbars desnity variations in the about3Pane. r=Paenglab

Comment 7

[Alessandro Castellani [:aleca]]

Comment on attachment 9344962 [details]
Bug 1843804 - Polish and solidify the various toolbars desnity variations in the about3Pane. r=#thunderbird-front-end-reviewers

[Approval Request Comment]
Regression caused by (bug #): -
User impact if declined: Inconsistent toolbar heights in the mail tab and a too tall unified toolbar in default density
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): very low as they're just CSS changes

Comment 8

[Wayne Mery (:wsmwk)]

Daily is much better. Thanks.

I'll file a follow up bug if anything else needs tweaking :)

Comment 9

[Wayne Mery (:wsmwk)]

Comment on attachment 9344962 [details]
Bug 1843804 - Polish and solidify the various toolbars desnity variations in the about3Pane. r=#thunderbird-front-end-reviewers

[Triage Comment]
Approved for beta
Approved for esr115 pending beta testing (to save time)

Comment 10

[Rob Lemley [:rjl]]

I'm not uplifting this as-is. Bug 1844231 changed the Windows version of multimessageview.css significantly enough that the patch does not apply.

Comment 11

[Alessandro Castellani [:aleca]]

Yeah, that was expected.
I'll create a patch for ESR.

Comment 12

[Alessandro Castellani [:aleca]]

Attachment: bug1843804-toolbar-heights-esr115.diff

Uploading ESR115 variation

Comment 13

[Rob Lemley [:rjl]]

Comment on attachment 9344962 [details]
Bug 1843804 - Polish and solidify the various toolbars desnity variations in the about3Pane. r=#thunderbird-front-end-reviewers

Doesnt apply

Comment 14

[Rob Lemley [:rjl]]

Comment on attachment 9345890 [details] [diff] [review]
bug1843804-toolbar-heights-esr115.diff

[Triage Comment]
Approving beta/esr version of previously approved patch.

Comment 15

[Rob Lemley [:rjl]]

Thunderbird 116.0b7:
https://hg.mozilla.org/releases/comm-beta/rev/836de57d0c2a

Comment 16

[Rob Lemley [:rjl]]

Thunderbird 115.1.0:
https://hg.mozilla.org/releases/comm-esr115/rev/8aceacfe536d