Closed Bug 1845391 Opened 1 year ago Closed 1 year ago

Message list sometimes scrolls after deleting a message

Categories

(Thunderbird :: Folder and Message Lists, defect, P2)

Product:
Thunderbird
Component:
Folder and Message Lists
Version:
Thunderbird 117
Type:
defect

Tracking

(thunderbird_esr102 unaffected, thunderbird_esr115+ fixed, thunderbird120+ fixed)

Status:
VERIFIED FIXED
Milestone:
121 Branch
Tracking Flags:
Tracking Status
thunderbird_esr102 --- unaffected
thunderbird_esr115 + fixed
thunderbird120 + fixed

People

(Reporter: soeren.hentzschel, Assigned: darktrojan)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1845391 - Refresh the thread tree without rebuilding it where possible. r=leftmostcat
48 bytes, text/x-phabricator-request
rjl
: approval-comm-beta+
wsmwk
: approval-comm-esr115+
Details | Review

It still sometimes happens that the message list jumps to a different position after deleting a message. Unfortunately I don't have any STR. I can only say that I have something in my quick filter text field and that the deleted mails were neither the oldest nor the newest mails, they were somewhere in the middle. I read and delete at least 100 mails per day and most times there are no issues, it only happens a few times per day. This makes it very difficult to provide more useful information.

Thunderbird Daily 117.0a1 (2023-07-21) on macOS 13.5.

Same as bug 1843462?

Maybe there is a similar cause but I don't think it's the same. Bug 1843462 says "new messages on the bottom(this is required)" but I have new messages on the top. I don't use the context menu. And it scrolls a bit but not "all the way to the top".

Summary: Message list still sometimes jumps after deleting a message → Message list sometimes scrolls after deleting a message
Flags: needinfo?(geoff)

Is this better on Daily now? I don't think the sort order matters for the changes I made in bug 1843462.

Flags: needinfo?(geoff) → needinfo?(soeren.hentzschel)

I tested again in Thunderbird Daily 118.0a1 (2023-08-04) and it happened two times.

Flags: needinfo?(soeren.hentzschel)

Happens in the release 115.1.1 all the time for me. There are two other bugs that are marked as fixed and verified, but that's not correct, the bug still exists! Bug 1835173 and bug 1833845. When I delete a message, the list jumps so far down that everything I previously saw is now out of view. Very annoying.

See Also: → 1844063
Duplicate of this bug: 1855337
Blocks: 1852392
Duplicate of this bug: 1852392
Blocks: 1844063
Duplicate of this bug: 1844063
See Also: 1844063 →
Blocks: 1853577
Duplicate of this bug: 1853577
Blocks: 1856780
Duplicate of this bug: 1856780
Blocks: 1844913

Is anyone using "Mark as Deleted" sever setting?

Flags: needinfo?(soeren.hentzschel)

Last fixes in this area were both fixed by leftmostcat and Geoff:

  • 115.0 (114.0b4) Bug 1833845 - Deleting a message frequently scrolls the message list, placing newly selected message at the bottom of the pane
  • 115.1.1 Bug 1835173 - Deleting a message frequently scrolls the message list, placing newly selected message at the bottom of the pane
  • 115.2.0 Bug 1843462 - Context menu delete scrolls message list to the top with smooth scrolling enabled (general.smoothScroll)
Severity: -- → S3
Priority: -- → P2

Is anyone using "Mark as Deleted" sever setting?

This happens on POP3 mail/local folders and news folders as well. Apparently not related to IMAP.

Is anyone using "Mark as Deleted" sever setting?

I do NOT have the "Mark as Deleted" server setting enabled.

Additional information: I use Thunderbird Daily and still see this behavior almost every day. The affected account is a Gmail account via IMAP. For my other accounts, I don't have enough email traffic to say if they are affected as well.

Flags: needinfo?(soeren.hentzschel)

Is anyone using "Mark as Deleted" sever setting?

I'm using "Move to this folder: " (and Trash selected).

I see it on both my accounts (self-deployed mailu and infomaniak). Though I don't think server is concerned here.

Also - it happens with "mark as read" (not only deleted)

Just get any newsgroup you don't care about and start deleting. Within 10 messages being deleted, you will see the effect.

Not reproducible for me using beta 119 with pop or newsgroups.

Then please use the release version. I deleted three news messages and it jumped on the third one. On the next try, I had to delete a whole lot more. In Daily I got it to jump once when deleting a lot of messages one at a time. You might not be able to reproduce it deleting 10 or 20 messages. The NG was downloaded for offline use.

no, not able to reproduce with any combination of positioning or message selection.

I received a bunch of e-mails from this bug today. Deleting the oldest one (down in the list) made the list jump right down. It happened a few times in a row, but then not anymore.

My observation is that the list would only jump if it was already scrolled a bit down. If the list view is scrolled to the very top, it doesn't jump anywhere.

I'm using the latest version 115.3.1.

Thank you for all the reports and tests on this.
We're aware of this issue and some of our core developers can reproduce it.

The problem is that it's not consistent.
The path to fix an issue is first being able to reproduce it consistently in order to identify the correct point of failure.

This issue is mostly sporadic, some of us don't even ever experience it. I myself experience it randomly only if I delete messages after opening and closing threads a couple of times, but if I redo the same steps it doesn't happen again. It's very random.

We will continue to investigate, but if anyone has any steps in which they can consistently reproduce it with certainty, that would be helpful.

I just tested Yves Goergen suggestion and indeed if the list is longer and the viewport is not at the end (max top or bottom) then the issue happens almost always for me. Maybe possibly it's also related to the fact that many messages are in the thread (can't test it now but I think that it's happen more often with threaded messages and if there are a couple of messages from the thread in particular box than in the single one-time mails without thread context)

I would discard any relations to threads. I'm not using them and still have the jumping.

I'm not using threaded view (for my inbox at least) but the notification from this issue ([Bug 1845391] Message list sometimes scrolls after deleting a message have In-Reply-To: <bug-1845391-488502@https.bugzilla.mozilla.org/> header) making it an email-thread even though we don't display it as such.

Duplicate of this bug: 1858703
Duplicate of this bug: 1858447
Duplicate of this bug: 1858190

I have a patch which improves this a lot. Not sure if it solves all cases. The patch is not in a shippable state just yet.

Assignee: nobody → geoff
Status: NEW → ASSIGNED

Thanks. It will be so great when it's fixed. Appreciate the hard work. David

status-thunderbird117: affected → ---
status-thunderbird_esr115: --- → affected
Keywords: checkin-needed-tb
Target Milestone: --- → 121 Branch

Pushed by brendan@thunderbird.net:
https://hg.mozilla.org/comm-central/rev/388b0ec45e22
Refresh the thread tree without rebuilding it where possible. r=leftmostcat

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Keywords: checkin-needed-tb
Resolution: --- → FIXED
status-thunderbird120: --- → affected
tracking-thunderbird120: --- → +
tracking-thunderbird_esr115: --- → +
Flags: needinfo?(vseerror)

Sören, and anyone using Daily...

How is today's daily build?

Flags: needinfo?(vseerror) → needinfo?(soeren.hentzschel)

So far, I didn't notice it in today's build. But since I didn't have the issue every day (while on other days it occurred a few times) I'll keep the needinfo? request for a few days.

Patch good for uplift?

Flags: needinfo?(geoff)
See Also: → https://support.mozilla.org/en-US/questions/thunderbird?tagged=tb115scroll&show=all

Comment on attachment 9359492 [details]
Bug 1845391 - Refresh the thread tree without rebuilding it where possible. r=leftmostcat

[Triage Comment]
Approved for beta. (prereq for bug 1845391)

Attachment #9359492 - Flags: approval-comm-beta+

So far, I didn't notice it in today's build. But since I didn't have the issue every day (while on other days it occurred a few times) I'll keep the needinfo? request for a few days.

I wasn't able to reproduce the issue in the last few days. Thanks for fixing it!

Flags: needinfo?(soeren.hentzschel)
Flags: needinfo?(geoff)

I'd like to take this for the next 115, build on Friday?, because unexpected scrolling is still a top user complaint, Geoff previously stated "patch ... improves this a lot.", and we have about 6 other bug reports https://mzl.la/3MwlBOv. I'm not seeing any new beta bugs reported since this landed on beta.

Sean, with Geoff away, can you speak to the solidity of this patch?

Flags: needinfo?(leftmostcat)

(In reply to Sören Hentzschel from comment #37)

I wasn't able to reproduce the issue in the last few days. Thanks for fixing it!

=> v.fixed

Status: RESOLVED → VERIFIED

Comment on attachment 9359492 [details]
Bug 1845391 - Refresh the thread tree without rebuilding it where possible. r=leftmostcat

[Triage Comment]
Approved for esr115

Geoff, if you disagree about taking this on esr please comment

Flags: needinfo?(leftmostcat)
Attachment #9359492 - Flags: approval-comm-esr115+
Duplicate of this bug: 1864091
Duplicate of this bug: 1857873
Duplicate of this bug: 1862731
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: