1846119 - The elements in the urlbar are not aligned with the dropdown when UI density is set to compact or touch

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P3)

Description

[tgn-ff]

Attachment: urlbar.png

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:109.0) Gecko/20100101 Firefox/117.0

Steps to reproduce:

I'm aware that the compact density is marked as unsupported.

1. Set the UI density to compact by setting browser.uidensity to 1.
2. Type something in the urlbar.

Actual results:

Icon and text in the urlbar are not aligned with icons and text in the dropdown, and the space between the magnifying glass and text in the urlbar seems larger than before.

Expected results:

This probably was regressed by Bug 1839921, but I can't verify it due to Bug 1845272.

I'm attaching a similar screenshot as the reporter in 1839921 to make the issue obvious.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:daleharvey, since you are the author of the regressor, bug 1839921, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Ardelean Oana, Desktop QA [:oardelean]]

Hello, thank you for the bug report!
Managed to reproduce on:

• Nightly 117.0a1;

Tested and reproduced on:

• Ubuntu 22;
• Windows 10:
• macOS 12:

Setting as NEW.

Comment 3

[Sam Johnson]

Attachment: Bug 1846119 - Align urlbar icons regardless of density. r?dao

This fixes the issue for all density modes, including compact and touch.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1839921

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4205d3ef6af6
Align urlbar icons regardless of density. r=dao

Comment 6

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/4205d3ef6af6

Comment 7

[Drew Willcoxon :adw]

Comment on attachment 9346594 [details]
Bug 1846119 - Align urlbar icons regardless of density. r?dao

Beta/Release Uplift Approval Request

• User impact if declined: We need this to ship the rich suggestions experiment on release as planned
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Should be clear from comments and screenshots
• List of other uplifts needed: The following bugs should be uplifted in this order: bug 1839921 (already on beta), Bug 1846119, Bug 1846765
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): CSS-only change that affects rich suggestions, which are preffed off by default except for Nightly
• String changes made/needed:
• Is Android affected?: No

Comment 8

[Dianna Smith [:diannaS] - on Leave, back on August 9th]

Comment on attachment 9346594 [details]
Bug 1846119 - Align urlbar icons regardless of density. r?dao

Approved for 117.0b3
Approved for 116.0.1 dot release

Comment 9

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/177fc125daaa

Comment 10

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-release/rev/e898dbd5930f

Comment 11

[Cristian Baica [:cbaica], Release Desktop QA]

The issue is verified fixed using Fx116.0.1 (treeherder build), Fx 117.0b3 (treeherder build) and Fx 118.0a1 on Windows 10 and Ubuntu 20.04. Icons are now aligned when having the compact view enabled.

Comment 12

[Dale Harvey (:daleharvey)]

clearing needinfo