1839921 - [Address Bar] Align urlbar favicon and text when rich entities are enabled

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P2)

Description

[Mehmet]

Attachment: actual.png

Nightly 116.0a1 (2023-06-22) (64-Bit)
macOS 13.4.1

Steps to reproduce:

1. Type something into the Address Bar
2. Take a look at the vertical alignment of text input and dropdown.

Actual: Elements are no longer aligned.

Expected: Favicons and text should be aligned.

Screenshots are attached.

This is a recent regression.

Comment 1

[Mehmet]

Attachment: expected.png

• Expected screenshot

Comment 2

[Mehmet]

I did a bisect:

Bug 1837815 - Enable rich entities in nightly. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D180590

dharvey@: Can you please take a look at this regression?

Many thanks :)

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1837815

Comment 4

[Dale Harvey (:daleharvey)]

When rich entities are enabled the favicons take up more space to allow for larger icons however when that happens we need to also adjust the spacing in the urlbar

Comment 5

[Dale Harvey (:daleharvey)]

Attachment: Bug 1839921 - Align urlbar and result icons when rich suggestions enabled. r=dao

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/49c2d107e082
Align urlbar and result icons when rich suggestions enabled. r=dao

Comment 7

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/49c2d107e082

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:daleharvey, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox116 to wontfix.

For more information, please visit BugBot documentation.

Comment 9

[Mehmet]

Attachment: fixed.png

Thanks for fixing the issue. Looks perfectly aligned again in Nightly 117.0a1 (2023-07-27) (64-Bit).

Comment 10

[Drew Willcoxon :adw]

Comment on attachment 9341258 [details]
Bug 1839921 - Align urlbar and result icons when rich suggestions enabled. r=dao

Beta/Release Uplift Approval Request

• User impact if declined: We need this to ship the rich suggestions experiment on release as planned
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Should be clear from the comments and screenshots
• List of other uplifts needed: The following bugs should be uplifted in this order: 1839921, Bug 1846119, Bug 1846765
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): CSS-only change that affects rich suggestions, which are preffed off by default except for Nightly
• String changes made/needed:
• Is Android affected?: No

Comment 11

[Dianna Smith [:diannaS]]

Comment on attachment 9341258 [details]
Bug 1839921 - Align urlbar and result icons when rich suggestions enabled. r=dao

Approved for 116.0.1 dot release

Comment 12

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-release/rev/06b6bc179b80

Comment 13

[Cristian Baica [:cbaica], Release Desktop QA]

The issue is verified fixed using Fx116.0.1 (treeherder build), Fx117.0b3 (treeherder build) and Fx 118.0a1 on Windows 10 and Ubuntu 20.04. Icons from the address bar are aligned with the icons from the drop-down.

Comment 14

[Dale Harvey (:daleharvey)]

Clearing needinfo