Closed Bug 1846543 Opened 1 year ago Closed 1 year ago

Some emails with attachments don't show them, have empty From/Subject displayed

Categories

(Thunderbird :: Folder and Message Lists, defect)

Product:
Thunderbird
Component:
Folder and Message Lists
Version:
Thunderbird 116
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED WORKSFORME

People

(Reporter: redux, Unassigned)

References

Details

Attachments

(8 files)

Composite screenshots showing the message as it opens (with empty from/subject), what it looks like when forwarding (with attachments showing), and what happens in the message list initially, after moving it to another folder, and then opening it
241.12 KB, image/png
Details
thunderbird-attachments-disappearing.gif
1.32 MB, image/gif
Details
TB 118.0b5 rc and gmail in a browser. The email in gmail shows a large number of attachments on the email sent to the account set up in TB. The received message in TB has no attachments nor icon
316.58 KB, image/png
Details
118.0b5 error console
42.25 KB, image/png
Details
118.0b6 broken behaviour
88.16 KB, image/png
Details
118.0b6 sometimes works again
136.03 KB, image/png
Details
119.0a1 fixes this for good
151.81 KB, image/png
Details
t.diff
2.82 KB, patch
Details | Diff | Splinter Review

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/115.0.0.0 Safari/537.36

Steps to reproduce:

This only seems to happen occasionally, but:

  1. Receive an email with attachments

Actual results:

In the message list, no attachment icon is shown.

When opening the email, no attachments are shown, and the "From" and "Subject" fields appear empty.

When forwarding the email, Thunderbird then does show me all the attachments that were in the email, so it is aware of them.

Moving the email to another folder, it initially then shows the attachment icon, but opening the message then results in the attachment icon disappearing again and the same broken display with missing "From"/"Subject" and no attachments

I tried looking in some obvious places like developer tools console, but didn't spot anything that might give a clue about this. It also only seems to happen occasionally.

Expected results:

The attachment icon should show in the message list, and when opening the email it should show the attachments, as well as the correct "From" and "Subject".

After forwarding the email in question, I can then see the attachments...the first time around. Leaving the message and returning to it, they disappear again. (see animated gif attachment).

It may be related to filename length perhaps? Some of those attachments do have exceedingly long names.

I am also having this issue, interestingly.. Click an email at the bottom with an attachment (old email), and click back the email without the attachment shown, the attachment can be seen in the email.

See Also: → 1844157
See Also: → 1840943

All,

Please test the 118.0b5 candidate build.
Details at https://thunderbird.topicbox.com/groups/beta/T482e51f86e162793-Md9dd8819657f2c81e37bcfd5
Just install over top your current beta program directory.

Flags: needinfo?(redux)

unfortunately problem is still present in 118.0b5

Flags: needinfo?(redux)

imap?
anything in tools > error console?

yes, it's an imap account. I don't have any POP accounts I could test on. error console doesn't show anything that seems relevant.

Attached image 118.0b5 error console —

Wayne, I downloaded 118.0b5 (from candidates area) and it doesn't seem to have the fix in it. I still see the problem on my test messages.
Specifically, in preview, header and attachment list often don't show. Have to select another message and then come back and then sometimes they show.

Wayne, the link to daily 119 does fix the bug!

(In reply to gene smith from comment #11)

Wayne, the link to daily 119 does fix the bug!

Interesting. Anything in https://mzl.la/3RkC0sM ?

(In reply to gene smith from comment #11)

Wayne, the link to daily 119 does fix the bug!

Great. Hopefully next week's beta 119 will solve the issue.

Whiteboard: [closeme 2023-10-1]
Component: Untriaged → Folder and Message Lists

just for my own interest, where can i find the daily 119? (apologies, i'm just a humble outsider here ;) )

You reported this bug as 116, which was a beta release - Help > About will update you to the latest version.
However, if 116 was an error and you are really using the 115 release, then I would stick with that.

I'm on 118.0b5 (64-bit) at the moment, and it tells me that TB is up to date. assume I'll just hang tight until next week (?) when 119 beta rolls out. I'll double-check this once I'm on 119 and report back here just in case. thanks :wsmwk

(In reply to Patrick H. Lauke from comment #14)

just for my own interest, where can i find the daily 119? (apologies, i'm just a humble outsider here ;) )

You can find today's daily/nightly here at the "archive" site:
https://archive.mozilla.org/pub/thunderbird/nightly/2023/09/2023-09-22-09-51-03-comm-central/thunderbird-119.0a1.en-US.win64.installer.exe
There is also an .msi installer if you prefer. There are also other OS types like linux and linux64 and mac64 in there.
There are daily/nightly versions in other languages under 2023-09-22-09-51-03-comm-central-l10n/ directory that I think are valid, but I've only ever used EN-us localization.

(In reply to Patrick H. Lauke from comment #16)

I'm on 118.0b5 (64-bit) at the moment, and it tells me that TB is up to date. assume I'll just hang tight until next week (?) when 119 beta rolls out. I'll double-check this once I'm on 119 and report back here just in case. thanks :wsmwk

118.0b6 shipped on Friday. You can update now :)

Flags: needinfo?(redux)

118.0b6 still has the current broken behaviour intermittently (first time, I see the attachments, then I go to another folder, come back, open the email again, the the sender, subject line, attachments are all blank).

119.0a1 daily does seem to fix this issue for good though.

Flags: needinfo?(redux)

I don't understand Patrick's findings, i.e. fixed in 119.0a1 but not fixed in 118.0b6. But it is potentially confirmed by Bug 1853594 - 118.0b5: Sometimes message displays no header when going quickly from mail to mail.

We need to identify the fix so it can be uplifted to version 115. I'm not finding anything in https://mzl.la/3rzbr8B. Maybe something attachment related? Other ideas?

Fixed in beta
118.0b5 fixed Bug 1840943 - Message headers missing in message preview for some messages (rarely, and random). Displays in message list.
118.0b6 fixed Bug 1851871 - Message header display delayed by images that are slow to load

Flags: needinfo?(geoff)

The earlier patch in bug 1840943 comment 6 was backed out from comm-central but remains on beta. It never went to ESR so that should behave the same way as Daily.

Flags: needinfo?(geoff)
Attached patch t.diff — — Splinter Review

Yes, changes to mock channel Close() handling in nsImapProtocol.cpp never got backed out for beta5 or 6.
It appears something like this attached patch need to be applied to comm-beta repo to fix the problem. (If I apply this patch to daily tip in reverse, i.e., patch -p1 -R < t.diff, I see the bug again on daily.)

(In reply to gene smith from comment #25)

Created attachment 9354792 [details] [diff] [review]
It appears something like this attached patch need to be applied to comm-beta repo to fix the problem.

If patch lands on c-c before tomorrow's merge, then it will effectively be on beta. That likely won't happen until 12-1pm eastern time.

(In reply to Wayne Mery (:wsmwk) from comment #26)

(In reply to gene smith from comment #25)

Created attachment 9354792 [details] [diff] [review]
It appears something like this attached patch need to be applied to comm-beta repo to fix the problem.

If patch lands on c-c before tomorrow's merge, then it will effectively be on beta. That likely won't happen until 12-1pm eastern time.

C-C already effectively has the Comment 25 patch and is correct. Comment 25 patch just shows how I think beta should be changed. So nothing needs to land on C-C, right?

Correct, if you put it that way.

In that case, for 115 we need the modified patch, which will come from bug 1840943 Comment 38.

Depends on: 1840943
Whiteboard: [closeme 2023-10-1]

Confirming that in the latest 119.0b1 I'm now running, the problem I experienced is now resolved.

Thanks for the update.

Status: UNCONFIRMED → RESOLVED
Closed: 1 year ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: