1853442 - Keyboard shortcuts are not being enabled/disabled correctly (was: Zoom in/out keyboard shortcuts not working)

Status: NEW

(Thunderbird :: Message Reader UI, defect, P1)

Description

[Randy Dunlap]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:109.0) Gecko/20100101 Firefox/117.0

Steps to reproduce:

Opened an email to read it. Then tried to zoom in using CTRL++. Font size does not change. If I use View + Zoom + In, the font size changes. After that I can successfully use CTRL++ or CTRL+- to zoom in/out (i.e., change the font sizes).

Actual results:

Font size does not change.

Expected results:

Font size should change without having to do extra menu steps (View/Zoom/In).

Comment 1

[Magnus Melin [:mkmelin]]

Seems to work just fine for me. Can you reproduce using Help | Troubleshoot mode?

Comment 2

[Randy Dunlap]

I got the same result - not working. Do you want a copy of the troubleshooting text info?

Comment 3

[Vefa]

I have been encountering the same issue with Thunderbird 115.3.2 on Linux/x86_64, using the official Thunderbird release tarball from thunderbird.net.

Here are additional pieces of information that might help with diagnosing this issue:

• The issue appears to affect e-mails opened/displayed in tabs.
• The keyboard shortcuts for zooming appear to always work when an e-mail is opened in a new window (as opposed to a tab).
• Once the issue is worked around with the use of the "View->Zoom->Zoom In" menu entry with an e-mail opened in a tab, then the issue is worked around until Thunderbird is restarted. That is, the keyboard shortcuts Ctrl++ and Ctr+- continue to work with e-mails opened in tabs until Thunderbird is restarted.
• Using the Ctrl+mouse scroll wheel combination to zoom in/out is another work-around that makes the Ctrl++ and Ctrrl+- keyboard shortcuts work in e-mail tabs until Thunderbird is restarted.
• Even though the keyboard shortcuts work in when opened in separate e-mail windows, simply opening an e-mail in a new window and making use of the keyboard shortcuts do not avoid the need to use the workaround for e-mails opened in tabs.

For the record, the issue is reproducible in Thunderbird's troubleshooting mode for me as well.

I hope that this is helpful. Thanks!

Comment 4

[Mark Banner (:standard8)]

I can reproduce this in various cases, especially on startup. I'm testing on Mac. No other extensions enabled

STR:

1. Start up Thunderbird with the 3-pane showing. The mail start page shows.
2. Press the keyboard shortcuts for Zoom in/out

• Nothing happens.

1. Select a different folder
2. Press the keyboard shortcuts for Zoom in/out

• Nothing happens.

1. Open and close the View menu (no need to select other items).
2. Press the keyboard shortcuts for Zoom in/out

• The shortcuts now work!

Here's another STR to trigger it if you have the command keys working:

1. Select a message in the message list
2. Deselect the message, so that nothing is displayed.
3. Go -> Mail Start Page.
4. Press the keyboard shortcuts for Zoom in/out

• Nothing happens.

From what I can tell, the only cases where the key status appear to be set/refreshed are:

• When the view menu is opened.
• When a message is selected in the message list.

This doesn't just apply to Zoom keys, other command keys are broken as well. For example:

1. On Mac select a message
2. open and close the message menu.
3. Press cmd-R -> Reply window opens, and so close that again.
4. Deselect the message or open a non-message tab (e.g. settings).
5. Press cmd-R

• The message menu flashes as if the command is trying to activate.

1. Open and close the message menu again
2. Press cmd-R

• The message menu no longer flashes.

I think these are the two main cases that are not being covered for refreshing the keys, but there may be more:

• Tab change
• When what is displayed in the message view is changed by anything other than clicking on the thread pane.

There was a partial fix made in bug 1839006. However, I think that missed a few things:

• It should have applied to all command keys (unfortunately this wasn't realised at the time).
• The fix should have been made inside messagePane, since that's the item that is responsible for displaying the different items in the message pane itself.
  • i.e. the fixes should be being triggered from messagePane.displayWebPage, messagePane.displayMessage and messagePane.displayMessages and the associated clear functions (though preferably in a way not to trigger multiple times per display change).
  • threadPaneHeader._onSelect does not cover the deselecting messages, or selecting different folders cases.

Confirming as there's enough evidence to show this is broken, and requesting tracking since this will potentially be a difficult regression for any keyboard heavy users.

Comment 6

[Elizabeth Mitchell]

Given that we have 2 Linux users confirming this and 1 macOS user confirming this, this is worth investigation.

With my own testing, I can't duplicate this on Windows 11 with TB 115.4.1 and TB 121. I can use Ctrl++ and Ctrl+- to zoom in and out of text (affects Message Reader font size).

Testing would be needed in Linux and macOS.

Comment 7

[Mark Banner (:standard8)]

(In reply to Elizabeth Mitchell from comment #6)

With my own testing, I can't duplicate this on Windows 11 with TB 115.4.1 and TB 121. I can use Ctrl++ and Ctrl+- to zoom in and out of text (affects Message Reader font size).

Did you try the STR I posted in comment 4? Just using ctrl +/- isn't necessarily going to reproduce it. I would be very surprised if this was only non-windows, unless there's some really special windows-only key handling going on there.

Comment 8

[Elizabeth Mitchell]

(In reply to Mark Banner (:standard8) from comment #7)

(In reply to Elizabeth Mitchell from comment #6)

With my own testing, I can't duplicate this on Windows 11 with TB 115.4.1 and TB 121. I can use Ctrl++ and Ctrl+- to zoom in and out of text (affects Message Reader font size).

Did you try the STR I posted in comment 4? Just using ctrl +/- isn't necessarily going to reproduce it. I would be very surprised if this was only non-windows, unless there's some really special windows-only key handling going on there.

Yes, I did follow your steps in comment 4. I was using Windows, however. So there is the possibility that this is Linux and macOS specific. But more testing would be needed to confirm that.

Comment 10

[Mark Banner (:standard8)]

I just verified that I can reproduce the non-mac specific parts of comment 4 on Windows on the latest Thunderbird 115. The Mac specific parts you can't reproduce because Windows doesn't flash the menu option like Mac does.

I also just verified that comment 4 also reproduces on 126.0b1.

Also, another bonus STR:

1. Open Thunderbird with the normal three-pane tab.
2. Open Settings
3. Try and adjust the Zoom with the shortcut keys.

=> Nothing happens unless you open/close the View menu.

Note the end of comment 4 has some theories on the way to fix this.

Adding a tracking request on this regression for 127, as that's the next major listed (though really thinking about 128).