1858053 - screenshot result is smaller than selected region when selecting "Zoom Text Only"

Status: RESOLVED WORKSFORME

(Firefox :: Screenshots, defect, P3)

Description

[Liu Sen]

Attachment: selected region, wrong result and correct result

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/118.0

Steps to reproduce:

Click "Take Screenshot" button, select a region and save the result.

If check "Zoom Text Only", result is smaller than selected region; if uncheck it, result is correct.

Comment 1

[Alice0775 White]

I can reproduce on Nightly120.0a1 Windows10.

Comment 2

[Alice0775 White]

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=54975222672eb7c4dbb86d4ec224ae8d1f91cec5&tochange=997d2fc150eea16afad461475fbcbcd582558a52

Suspect: Bug 1681869 and Bug 1664444
Tentatively, mark Bug 1681869 as regressor.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1681869

:sotaro, since you are the author of the regressor, bug 1681869, could you take a look?

For more information, please visit BugBot documentation.

Comment 4

[Sam Foster [:sfoster] (he/him)]

Right next to bug 1681869 in the pushlog is bug 1664444 which could easily be the regressor also.
And since that time we've forked this code to create a non-extension based Screenshots implementation, possibly baking in the same bug.

Alice0775 White, can you also reproduce with screenshots.browser.component.enabled set to true?

Comment 5

[Alice0775 White]

(In reply to Sam Foster [:sfoster] (he/him) from comment #4)

Right next to bug 1681869 in the pushlog is bug 1664444 which could easily be the regressor also.
And since that time we've forked this code to create a non-extension based Screenshots implementation, possibly baking in the same bug.

Alice0775 White, can you also reproduce with screenshots.browser.component.enabled set to true?

Yes, screenshots.browser.component.enabled = true fix this issue.

However, after scrolling down the web page, the UI and dimmed areas of the screenshot are out of the view-port. (may be another bug)

Comment 6

[Sam Foster [:sfoster] (he/him)]

(In reply to Alice0775 White from comment #5)

Alice0775 White, can you also reproduce with screenshots.browser.component.enabled set to true?
Yes, screenshots.browser.component.enabled = true fix this issue.

Ok, thanks for confirming. I'll put this in the backlog. Its likely we'll flip that pref before we fix this in the extension.

:sotaro, if you do track down what broke this, please need-info me.

However, after scrolling down the web page, the UI and dimmed areas of the screenshot are out of the view-port. (may be another bug)

Yes, this is bug 1857946

Comment 7

[Sam Foster [:sfoster] (he/him)]

I don't think we need any more info here. This will be fixed when bug 1789727 is fixed.

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1681869

Comment 12

[Niklas Baumgardner [:niklas]]

This is fixed in the screenshots component. We enabled the component in bug 1870127