1862693 - Use 1-origin column number in debugger API

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Description

[Tooru Fujisawa [:arai]]

After bug 1862692, we can rewrite the Debugger API to use 1-origin column number, and rewrite the DevTools Debugger code to directly use the 1-origin column number, instead of performing the conversion there.

Comment 1

[Tooru Fujisawa [:arai]]

There's one problem around bug 1863878.
wasm debugger had been using column 1, which had been treated as "1 in 0-origin", but it doesn't have to become "2 in 1-origin",
so the conversion should be done only when the script/source isn't "wasm".
the related debugger code will have the conditional conversion code until the entire debugger internal gets migrated to 1-origin.

Comment 2

[Tooru Fujisawa [:arai]]

Attachment: Bug 1862693 - Use 1-origin column number in debugger API. r?iain!,ochameau!

This includes the following API:

• Debugger.Object.prototype.createSource
  • startColumn field of the parameter object
• Debugger.Script.prototype.startColumn
  • return value
• Debugger.Script.prototype.getPossibleBreakpoints
  • minColumn and maxColumn property of the query
  • columnNumber property of the returned array elements
• Debugger.Script.prototype.getOffsetMetadata
  • columnNumber property of the returned array elements
• Debugger.Script.prototype.getOffsetLocation
  • columnNumber property of the returned array elements
• Debugger.Script.prototype.getAllColumnOffsets
  • columnNumber property of the returned array elements
• Debugger.Script.prototype.getOffsetsCoverage
  • columnNumber property of the returned array elements
• Debugger.Source.prototype.startColumn
  • return value

This patch modifies DevTools code to convert the column number from/to 1-origin,
while keep using 0-origin on their side.

One exception is the WASM's column number, which had been using 1-origin 1.
Each consumer in DevTools handles the WASM case, and the code can be removed
once DevTools internal also switches to 1-origin column number.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/39867b503289
Use 1-origin column number in debugger API. r=iain,ochameau,devtools-reviewers

Comment 5

[Natalia Csoregi [:nataliaCs]]

Backed out along with Bug 1864155, Bug 1864168, Bug 1862814 , Bug 1865005 for causing bustage on nsRFPService.cpp

• backout: https://hg.mozilla.org/integration/autoland/rev/275cd8d44829f57197d7d70055f5a88bf890d153

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e2b664dff2c2
Use 1-origin column number in debugger API. r=iain,ochameau,devtools-reviewers

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/e2b664dff2c2