1862814 - Use 1-origin column number for observable script position

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Description

[Tooru Fujisawa [:arai]]

bug 1862692 will fix the underlying data representation to use 1-origin column number, while keeping the observable column number as 0-origin.
This bug is to change the script position in error message, error stack, etc, into 1-origin.

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Bug 1862814 - Part 1: Use 1-origin column number in Reflect.parse. r?iain!

Depends on D193374

Comment 2

[Tooru Fujisawa [:arai]]

Attachment: Bug 1862814 - Part 2: Use 1-origin column number in script-related dump. r?iain!

Depends on D193375

Comment 3

[Tooru Fujisawa [:arai]]

Attachment: Bug 1862814 - Part 3: Use 1-origin column number in JitSpew. r?iain!

Depends on D193376

Comment 4

[Tooru Fujisawa [:arai]]

Attachment: Bug 1862814 - Part 4: Use 1-origin column number in testing function compile options. r?iain!

Depends on D193377

Comment 5

[Tooru Fujisawa [:arai]]

Attachment: Bug 1862814 - Part 5: Remove zeroOriginValue methods from column number classes. r?iain!

The "OneOrigin" name should be kept in the class names and method names until
the remaining part of Gecko and DevTools are also migrated to 1-origin,
in order to clarify where the conversion is necessary.

Depends on D193378

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8ee94e5e79c2
Part 1: Use 1-origin column number in Reflect.parse. r=iain
https://hg.mozilla.org/integration/autoland/rev/1378502e64b0
Part 2: Use 1-origin column number in script-related dump. r=iain
https://hg.mozilla.org/integration/autoland/rev/e340886ce62a
Part 3: Use 1-origin column number in JitSpew. r=iain
https://hg.mozilla.org/integration/autoland/rev/a679b50dc4a9
Part 4: Use 1-origin column number in testing function compile options. r=iain
https://hg.mozilla.org/integration/autoland/rev/ab38141e470b
Part 5: Remove zeroOriginValue methods from column number classes. r=iain

Comment 7

[Natalia Csoregi [:nataliaCs]]

Backed out along with Bug 1862693, Bug 1864155, Bug 1864168, Bug 1865005 for causing bustage on nsRFPService.cpp.

• backout: https://hg.mozilla.org/integration/autoland/rev/275cd8d44829f57197d7d70055f5a88bf890d153

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/78f9d23245a7
Part 1: Use 1-origin column number in Reflect.parse. r=iain
https://hg.mozilla.org/integration/autoland/rev/aeafc420949c
Part 2: Use 1-origin column number in script-related dump. r=iain
https://hg.mozilla.org/integration/autoland/rev/b800850c4a47
Part 3: Use 1-origin column number in JitSpew. r=iain
https://hg.mozilla.org/integration/autoland/rev/d55df96a49a2
Part 4: Use 1-origin column number in testing function compile options. r=iain
https://hg.mozilla.org/integration/autoland/rev/da7b4bde2fd3
Part 5: Remove zeroOriginValue methods from column number classes. r=iain

Comment 9

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/78f9d23245a7
https://hg.mozilla.org/mozilla-central/rev/aeafc420949c
https://hg.mozilla.org/mozilla-central/rev/b800850c4a47
https://hg.mozilla.org/mozilla-central/rev/d55df96a49a2
https://hg.mozilla.org/mozilla-central/rev/da7b4bde2fd3