1870332 - Implement Select Translations Panel Translate Full Page Button

Status: RESOLVED FIXED

(Firefox :: Translations, task, P3)

Description

[Erik Nordin [:nordzilla]]

Description

This bug tracks the progress of implementing the Translations Settings Panel Translate full page button functionality.

When the button is clicked, the panel should close and the full-page translations feature should trigger.

---

Steps to implement

• Close the Select Translations Panel on click
• Trigger full page translations on click

---

Tests to implement

• Test that the full page is translated when the button is clicked.
• Test that the unsupported language view shows when requesting full-page translations on an unsupported language page.

Comment 1

[Erik Nordin [:nordzilla]]

Attachment: Bug 1870332 - Remove translator cache from SelectTranslationsPanel r=#translations-reviewers!

Removes the translator cache from the SelectTranslationsPanel,
instead creating a fresh port for each translation.
The Engine cache is already maintained externally, and it doesn't
make much sense to try to maintain a separate cache on top of it.

Comment 2

[Erik Nordin [:nordzilla]]

Attachment: Bug 1870332 - Implement SelectTranslationsPanel translate-full-page button r=#translations-reviewers!

Implements the functionality of clicking the
translate-full-page button in the SelectTranslationsPanel.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/69d58e7adf3b
Remove translator cache from SelectTranslationsPanel r=translations-reviewers,gregtatum
https://hg.mozilla.org/integration/autoland/rev/3764430d94d6
Implement SelectTranslationsPanel translate-full-page button r=translations-reviewers,gregtatum

Comment 4

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/69d58e7adf3b
https://hg.mozilla.org/mozilla-central/rev/3764430d94d6