1880357 - Rename TranslationsPanel to FullPageTranslationsPanel

Status: RESOLVED FIXED

(Firefox :: Translations, enhancement, P3)

Description

[Erik Nordin [:nordzilla]]

Description

This bug tracks the progress of renaming the full-page translations panel to say FullPageTranslationsPanel in the code instead of just TranslationsPanel.

The panel was created at a time when there was only one panel. Now that there are two, it would be more clear if the naming was distinguished with "FullPage"

---

Steps to implement

• Rename files related to the panel from translationsPanel... to fullPageTranslationsPanel...
• Rename XUL/HTML element ids from translations-panel-... to full-page-translations-panel-...
• Rename test file names from browser_translations_panel... to browser_translations_full_page_panel....
• Rename the TranslationsPanel class itself to FullPageTranslationsPanel.

Comment 1

[Erik Nordin [:nordzilla]]

Attachment: Bug 1880357 - Rename translationsPanel.(inc.xhtml|js) r=#translations-reviewers!

Renames the files translationsPanel... to fullPageTranslationsPanel...
to more accurately reflect what it is, now that there are
two translations panels.

Depends on D200506

Comment 2

[Erik Nordin [:nordzilla]]

Attachment: Bug 1880357 - Rename fullPageTranslationsPanel ids r=#translations-reviewers!

Renames the XUL/HTML element ids of the fullPageTranslationsPanel
to be full-page-translations-panel-... to distinguish them
from the select-translations-panel-... ids.

Depends on D200857

Comment 3

[Erik Nordin [:nordzilla]]

Attachment: Bug 1880357 - Rename full-page Translations tests r=#translations-reviewers!

Renames test files in the Translations test suite that
deal with full-page translations to say full_page in the
name of the test file.

Depends on D200876

Comment 4

[Erik Nordin [:nordzilla]]

Attachment: Bug 1880357 - Rename TranslationsPanel to FullPageTranslationsPanel r=#translations-reviewers!

Renames the TranslationsPanel class itself to FullPageTranslationsPanel
to distinguish it from the SelectTranslationsPanel class.

Depends on D200877

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e51c1dfb0767
Rename translationsPanel.(inc.xhtml|js) r=translations-reviewers,gregtatum
https://hg.mozilla.org/integration/autoland/rev/3c0376cf5b5f
Rename fullPageTranslationsPanel ids r=translations-reviewers,desktop-theme-reviewers,emilio,gregtatum
https://hg.mozilla.org/integration/autoland/rev/0e3db2effde6
Rename full-page Translations tests r=translations-reviewers,gregtatum
https://hg.mozilla.org/integration/autoland/rev/9f0a36ad783e
Rename TranslationsPanel to FullPageTranslationsPanel r=translations-reviewers,gregtatum

Comment 6

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/e51c1dfb0767
https://hg.mozilla.org/mozilla-central/rev/3c0376cf5b5f
https://hg.mozilla.org/mozilla-central/rev/0e3db2effde6
https://hg.mozilla.org/mozilla-central/rev/9f0a36ad783e