1880690 - Handle comm-esr115 failure in mailnews/base/test/unit/test_accountMgr2.js

Status: RESOLVED FIXED

(Thunderbird :: Account Manager, defect)

Description

[betterbird.project+14]

This
https://searchfox.org/comm-esr115/rev/eabfed25d212a3671c1c0da2091e629f7a08caf4/mailnews/base/test/unit/test_accountMgr2.js#164-168
fails on ESR 115, since createIncomingServer() doesn't support unicode parameters. They are only supported after this change:
https://hg.mozilla.org/comm-central/rev/ae2ec9897473#l24.51

The test failure is visible as X1 on the ESR 115 tree since 115.7.0.

Comment 1

[betterbird.project+14]

Is there any particular reason why in that changeset APIs related to ASCII keys were changed from ACString to AUTF8String, like for example here:
https://hg.mozilla.org/comm-central/rev/ae2ec9897473#l24.12

Comment 2

[Magnus Melin [:mkmelin]]

Bug 1865068 is not very appropriate to uplift. Probably best to disable that part of the test and leave the functionality broken for 115 (like it was forever).

Comment 3

[Magnus Melin [:mkmelin]]

Attachment: bug1880690_115_acctmgr.patch

Comment 4

[[e-mail]]

How about just backporting the IDL change? These three lines:
https://hg.mozilla.org/comm-central/rev/ae2ec9897473#l24.51

Comment 5

[Rob Lemley [:rjl]]

Comment on attachment 9380800 [details] [diff] [review]
bug1880690_115_acctmgr.patch

Review of attachment 9380800 [details] [diff] [review]:
-----------------------------------------------------------------

Works for me. Will get into next 115 release.

Comment 6

[Daniel Darnell [:dandarnell]]

Thunderbird 115.8.1:
https://hg.mozilla.org/releases/comm-esr115/rev/251aa4080109

Comment 7

[[e-mail]]

The test still fails:

Unexpected exception NS_ERROR_FAILURE: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIIOService.newURI]
@Z:/task_170915039895512/build/tests/xpcshell/tests/comm/mailnews/base/test/unit/test_accountMgr2.js:190:17

https://searchfox.org/comm-esr115/rev/0ec42c71066a867a26c7546b296a115bf7c82af9/mailnews/base/test/unit/test_accountMgr2.js#190

Comment 8

[Magnus Melin [:mkmelin]]

Attachment: 1880690.patch

The later part of the test also needs disabling

Comment 9

[Rob Lemley [:rjl]]

Comment on attachment 9388671 [details] [diff] [review]
1880690.patch

Review of attachment 9388671 [details] [diff] [review]:
-----------------------------------------------------------------

r+a for esr115.

Comment 10

[Rob Lemley [:rjl]]

Thunderbird 115.8.1+:
https://hg.mozilla.org/releases/comm-esr115/rev/6ca5941d9732