1870720 - Error 0x80004005 NS_ERROR_FAILURE with an idn domain

Status: RESOLVED FIXED

(Thunderbird :: Account Manager, defect)

Description

[l.fuerderer]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:120.0) Gecko/20100101 Firefox/120.0

Steps to reproduce:

• Start with a completely fresh Thunderbird profile
• Choose a mail server with an idn domain name
• Setup IMAP and SMTP with "Manual configuration" using the punycode (xn--*) domain as imap server / smtp server hostname
• Click on "Re-test" (green box appears), then click on "Done".

Actual results:

I see a yellow box with the content:
Component returned failure code: 0x80004005
(NS_ERROR_FAILURE) [nsIMsgIncomingServer.verifyLogon]
Below that, it says "Checking password..." with a loading indicator that runs without ending. (I waited at least 5 minutes)

This error occurs in Thunderbird version 115.5.2 but not in 115.5.1

Expected results:

The mail account should be successfully configured, Thunderbird should change to the main screen and start loading mails.

Comment 1

[Magnus Melin [:mkmelin]]

And if you use the real domain? (Non punycode one)

Comment 2

[Magnus Melin [:mkmelin]]

Would likely be from bug 1857824.
But entering the host in punycode to begin with would be a bit unexpected.

Comment 3

[l.fuerderer]

Thunderbird asks for name, mail address and password first, before I can change individual IMAP / SMTP settings.

When I enter my mail address with the hostname part in non-ascii form, Thunderbird complains right away:
"Hostname is empty or contains forbidden characters. Only letters, numbers, - and . are allowed."

When I use the punycode first for my mail address but enter the non-ascii hostname into the IMAP / SMTP hostname fields and click on Re-Test, the hostnames are automatically replaced by their punycode counterpart.
The "Done" button is grayed out until I click on Re-Test. Clicking Done after this auto-replacement results in the same Issue as described in my opening post.

Comment 5

[Magnus Melin [:mkmelin]]

Attachment: Bug 1870720 - Account for hostnames that were entered as punycode. r=#thunderbird-reviewers

Bug 1857824 made IDN hostnames that were entered as normal text work (not break the UI), but
didn't account for accounts that were entere as punycode to begin with.

That bug normalized the hostname from the url. This normalizes the actual hostname pref as well.

Bug 1871164 has good steps to reproduce.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/a00fee758b02
Account for hostnames that were entered as punycode. r=babolivier

Comment 8

[Magnus Melin [:mkmelin]]

Comment on attachment 9369844 [details]
Bug 1870720 - Account for hostnames that were entered as punycode. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #): bug 1857824
User impact if declined: can't enter idn account
Testing completed (on c-c, etc.): c-c
Risk to taking this patch (and alternatives if risky): fairly safe, adds automated test

Comment 9

[Wayne Mery (:wsmwk)]

Comment on attachment 9369844 [details]
Bug 1870720 - Account for hostnames that were entered as punycode. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta

Comment 10

[Rob Lemley [:rjl]]

Thunderbird 122.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/1f230b9d0eb4

Comment 11

[Wayne Mery (:wsmwk)]

Comment on attachment 9369844 [details]
Bug 1870720 - Account for hostnames that were entered as punycode. r=#thunderbird-reviewers

[Triage Comment]
Approved for esr115

Comment 12

[Daniel Darnell [:dandarnell]]

Thunderbird 115.7.0:
https://hg.mozilla.org/releases/comm-esr115/rev/d8a8ded00dd0

Comment 14

[Geoff Lankow (:darktrojan)]

The test added in this bug does not pass on ESR. Is comm-esr115 missing something, or is mozilla-esr115 missing something?

Comment 15

[Magnus Melin [:mkmelin]]

Bug 1880690 takes care.

Comment 16

[ISHIKAWA, Chiaki]

I have removed a MOZ_CRASH I see with a patch in
https://phabricator.services.mozilla.com/D216180

But obviously there are other issues.

Comment 17

[ISHIKAWA, Chiaki]

Oops, I meant the comment 16 for a different Bug 1906992.