1883042 - [DE][newbalance.de] Form autofill/preview/clear isn't applied on the "Address" field

Status: NEW

(Toolkit :: Form Autofill, task, P3)

Description

[Hani Yacoub, Desktop QA]

Attachment: Screen Recording 2024-03-01 at 15.59.21.mov

Found in

• Firefox Nightly 125.0a1

Affected versions

• Firefox Nightly 125.0a1

Tested platforms

• Affected platforms: macOS 11.6

Preconditions

• Install DE Firefox build
• Use DE VPN
• browser.search.region = DE
• extensions.formautofill.addresses.experiments.enabled - true
• extensions.formautofill.addresses.supportedCountries = DE
• extensions.formautofill.addresses.capture.requiredFields = empty
• Make sure to have a couple of addresses saved

Steps to reproduce

1. Reach the address form on https://www.newbalance.de
2. Click on "name" field
3. Select any of the options for the dropdown
4. Observe "Address" field
5. Fill the "Address" field with a valid address
6. Observe "Zip" and "City" fields.

Expected result

• Form autofill/preview/clear should be applied on eligible fields.

Actual result

• Form autofill/preview/clear isn't applied on the "Address" field.

Regression range

• N/A

Additional notes

• Not reproducible on Chrome.

Comment 1

[Hani Yacoub, Desktop QA]

Attachment: newbalance.html

Comment 2

[Neil Deakin]

I can't reproduce this issue right now.

Comment 3

[Neil Deakin]

Can't reproduce this. I can however see the issue in the attached testcase, but the street address field there is incorrectly labelled with autocomplete="new-password", so we don't treat it as an address. Chrome doesn't fill it in either. Since that is just a bug in the webpage I think we should not do anything with that.

But I don't see any issue with the current newbalance.de page. Perhaps we should just close this bug?

Comment 4

[Neil Deakin]

This isn't working any more. The city and postal code start out hidden and these input fields are only shown when the street is filled in.

Bug 1883038 and bug 1883339 have the same underlying cause. It is likely that bug 1923615 caused this regression. The solution is probably to reanalyze the form when filling in and capturing to see if new input elements are present.

dimi, is this something that you were aware of?

Comment 5

[Dimi Lee [:dimi]]

(In reply to Neil Deakin from comment #4)

This isn't working any more. The city and postal code start out hidden and these input fields are only shown when the street is filled in.

I think that means we should fix this issue within Bug 1837161.

Bug 1883038 and bug 1883339 have the same underlying cause. It is likely that bug 1923615 caused this regression. The solution is probably to reanalyze the form when filling in and capturing to see if new input elements are present.

Yes, we need to check whether the number of elements in a form is changed and monitor element's visibility.