1883736 - Add disk size measurements for all logins, keys, certificates and payment methods stores

Status: RESOLVED FIXED

(Firefox :: Profile Backup, task, P3)

Description

[Mike Conley (:mconley) (:⚙️)]

There's some shared infrastructure here with bug 1883642 (for the metrics.yaml file, for setting up the private method in BackupService that does measurement, and for test infrastructure).

This is the set of things to measure the size of:

• cert9.db
• key4.db
• logins.json
• logins-backup.json
• autofill-profiles.json
• credentialstate.sqlite
• pkcs11.txt

Similar to bug 1883655 and bug 1883642, this is a matter of adding some quantity probes, and then stat'ing these files, converting the measurement to kilobytes, and recording them to the Glean probes. We'll need a data-review and tests. Don't forget about ./mach data-review to help you out!

Comment 1

[kpatenio]

Attachment: Bug 1883736 - Add disk size measurements for all logins, keys, certificates and payment methods stores. r=#backup-reviewers!

Comment 2

[kpatenio]

Attachment: Data collection request

Comment 3

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Comment on attachment 9392102 [details]
Data collection request

data-review+

Thanks for fuzzing the data in these probes 👍

1. Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?

Yes.

2. Is there a control mechanism that allows the user to turn the data collection on and off?

Yes, the Firefox data collection opt out in about:preferences.

3. If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, mconley will monitor.

4. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 1, technical data.

5. Is the data collection request for default-on or default-off?

Default on.

6. Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?

No.

7. Is the data collection covered by the existing Firefox privacy notice?

Yes.

8. Does the data collection use a third-party collection tool?

No.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6af31d6cb21a
Add disk size measurements for all logins, keys, certificates and payment methods stores. r=backup-reviewers,mconley

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/6af31d6cb21a