1889109 - @scope Interacts Poorly with Style Sharing

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[David Shin[:dshin]]

Attachment: Minimum Reproducible Case

See attached test case, after bug 1886441. Discovered via cousin-sharing issue in WPT test.
Given a sibling or a cousin, we can't easily determine if one will be affected by a scoped style or not.

Comment 1

[David Shin[:dshin]]

Attachment: Bug 1889109: Part 1 - Get rid of now-unused relative selector flags. r=#style

Supplanted by Bug 1876962 making :has a revalidation selector.
Remaining reference was added during Bug 1869771, is still handled
by the revalidation logic (has-style-sharing-007.html stil passes).

Comment 2

[David Shin[:dshin]]

Attachment: Bug 1889109: Part 2 - Mark all elements considering scoped styles. r=#style

This lets us avoid having to run scope matching for revalidation
for elements that don't match scoped styles.

Depends on D212725

Comment 3

[David Shin[:dshin]]

Attachment: Bug 1889109: Part 3 - Add scope revalidation to style sharing. r=#style

Depends on D212726

Comment 4

[David Shin[:dshin]]

Attachment: Bug 1889109: Part 4 - Pull out mapping from "unique" selector attribute mappings. r=#style

Depends on D212727

Comment 5

[David Shin[:dshin]]

Attachment: Bug 1889109: Part 5 - Add scope subject map and use it to early-reject elements that can't be scopes. r=#style

Depends on D212728

Comment 6

[David Shin[:dshin]]

Attachment: Bug 1889109: Part 6 - Skip style sharing revalidation for trivial styles. r=#style

Depends on D212729

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/701c95daa818
Part 1 - Get rid of now-unused relative selector flags. r=firefox-style-system-reviewers,emilio
https://hg.mozilla.org/integration/autoland/rev/39fc87365e1d
Part 2 - Mark all elements considering scoped styles. r=firefox-style-system-reviewers,emilio
https://hg.mozilla.org/integration/autoland/rev/429be2a21d43
Part 3 - Add scope revalidation to style sharing. r=firefox-style-system-reviewers,emilio
https://hg.mozilla.org/integration/autoland/rev/35ccb8fc2227
Part 4 - Pull out mapping from "unique" selector attribute mappings. r=firefox-style-system-reviewers,emilio
https://hg.mozilla.org/integration/autoland/rev/625bf36ec294
Part 5 - Add scope subject map and use it to early-reject elements that can't be scopes. r=firefox-style-system-reviewers,emilio
https://hg.mozilla.org/integration/autoland/rev/d11ecdd691e5
Part 6 - Skip style sharing revalidation for trivial styles. r=firefox-style-system-reviewers,emilio

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/47138 for changes under testing/web-platform/tests

Comment 10

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/701c95daa818
https://hg.mozilla.org/mozilla-central/rev/39fc87365e1d
https://hg.mozilla.org/mozilla-central/rev/429be2a21d43
https://hg.mozilla.org/mozilla-central/rev/35ccb8fc2227
https://hg.mozilla.org/mozilla-central/rev/625bf36ec294
https://hg.mozilla.org/mozilla-central/rev/d11ecdd691e5

Comment 11

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot