1892732 - [Experiment] The "Learn more about Firefox Suggest" option for Yelp and MDN results is not working on Firefox 125

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Cosmin Muntean [:cmuntean], Ecosystem QA]

Attachment: Learn more about Firefox Suggest not working.mp4

[Affected versions]:

• Firefox Release 125.0.2
• Firefox Release 125.0.1

[Affected Platforms]:

• Windows 10
• macOS 13.1
• Ubuntu 22.4

[Prerequisites]:

• Be enrolled in the Yelp experiment.
• Have the browser.search.region set to "US".

[Steps to reproduce]:

1. Open the Firefox browser using the profile from prerequisites.
2. In the urlbar type a keyword that triggers a Yelp suggestion (eg: restaurant).
3. Click the "Feedback" button of the Yelp result.
4. Click the "Learn more about Firefox Suggest" option.
5. Observe the behavior.

[Expected result]:

• The Firefox Suggest SUMO page is opened in a new tab.

[Actual result]:

• Nothing happens.

[Regression]

• The issue is NOT reproducible on Firefox 124 release, considering this using mozregression tools we have found the following pushlog: Link.
• Based on the Pushlog link, it seems that Bug 1883378 introduced this behavior.

[ Notes]:

• Due to the changes made starting with Firefox 126, the issue is not reproducible because the "Learn more about Firefox Suggest" option was changed to "Manage Firefox Suggest".
• This issue is also reproducible for MDN suggestions.
• The issue is NOT reproducible for Pocket, Weather, Navigational, Dynamic Wikipedia
• Attached is a screen recording of the issue.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1883378

:daleharvey, since you are the author of the regressor, bug 1883378, could you take a look?

For more information, please visit BugBot documentation.

Comment 2

[Drew Willcoxon :adw]

I ended up investigating this and have a patch, so I'll take it.

Comment 3

[Drew Willcoxon :adw]

Attachment: Bug 1892732 - Fix the urlbar help command for results that don't define a help URL.

When UrlbarView handles the help command for a result, first it determines the
result's help URL. If result.payload.helpUrl is defined it uses that, and
otherwise it falls back to generating a default help URL. Either way, then it
sets menuitem.dataset.url to the help URL and calls input.pickResult().

Before bug 1883378, pickResult() would similarly first check
result.payload.helpUrl and then fall back to menuitem.dataset.url when
determining the help URL to load. Bug 1883378 changed this behavior so that it
only checks result.payload.helpUrl. That means we break any provider that
implements the help command but doesn't define a help URL on its results, like
Yelp and MDN.

One way to fix this would be to make sure providers that implement the help
command always define a help URL on their results. I don't like that idea
because it's nice for providers to be able to rely on a default help URL that's
defined elsewhere.

Another fix would be to always use menuitem.dataset.url in pickResult() and
don't check result.payload.helpUrl at all. That would work for result menu
items, but it wouldn't work for other elements like buttons that don't go
through the result-menu-command path. I don't know if we currently have any such
paths but I don't want to break something else.

So instead I think we should just go back to the status quo before bug 1883378:
First check result.payload.helpUrl if the command is help, and then fall back
to menuitem.dataset.url.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0383409744af
Fix the urlbar help command for results that don't define a help URL. r=daleharvey

Comment 5

[tszentpeteri]

https://hg.mozilla.org/mozilla-central/rev/0383409744af

Comment 6

[Donal Meehan [:dmeehan]]

:ada there's some discussion around this in the QA report from https://mozilla-hub.atlassian.net/browse/QA-2402
Please add a beta uplift on this to at least get this into Fx126

Comment 7

[Drew Willcoxon :adw]

Working on it now.

Comment 8

[Drew Willcoxon :adw]

Comment on attachment 9397933 [details]
Bug 1892732 - Fix the urlbar help command for results that don't define a help URL.

Beta/Release Uplift Approval Request

• User impact if declined: This bug is present on 125 and 126, so I'm requesting uplift to both just to cover bases, in case we do another 125 dot release. On 126, this bug is mostly moot because we changed the "Learn more about Firefox Suggest" menu item to the "Manage Firefox Suggest" menu item for most Suggest results, including Yelp and MDN (bug 1889820, bug 1891602, bug 1882677). Pocket suggestions still use "Learn more" but they're disabled; there may be other non-Suggest urlbar results that are affected, I'm not sure.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Should be clear from comments
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Very small change that reinstates a code path fallback that was removed by the regressing bug. Has tests.
• String changes made/needed:
• Is Android affected?: No

Comment 9

[Donal Meehan [:dmeehan]]

Comment on attachment 9397933 [details]
Bug 1892732 - Fix the urlbar help command for results that don't define a help URL.

Approved for 126.0b5

Comment 10

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/21adae7c7910

Comment 11

[Cosmin Muntean [:cmuntean], Ecosystem QA]

I have verified this issue on the latest Nightly 127.0a1 (Build ID: 20240424093459), latest Beta 126.0b5 (Build ID: 20240424091756) on Windows 10, macOS 13.1 and Linux Mint 20.1.

• Due to the fact that starting with Firefox 126 Yelp and MDN results have the new option "Manage Firefox Suggest", I have verified that the option still works and there are no issues.
• However, I have verified the "Learn more about Firefox Suggest" option for dynamic-wikipedia, pocket and navigational results.

No issues were found during testing. I will re-verify the issue in case it will be uplifted to Firefox 125 dot release.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9397933 [details]
Bug 1892732 - Fix the urlbar help command for results that don't define a help URL.

Approved for 125.0.3

Comment 13

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-release/rev/a7663c768a12

Comment 14

[Cosmin Muntean [:cmuntean], Ecosystem QA]

I have verified the issue on the new Firefox 125.0.3 dot release (Build ID: 20240425211020) on Windows 10 x64, macOS 14.4.1 and Linux Mint 20.1.

• The "Learn more about Firefox Suggest" option for Yelp and MDN results is working as expected and opens the SUMO page for Firefox Suggest.
• Verified the option also for the other Firefox Suggest results: sponsored, non-sponsored, dynamic-wikipedia, pocket, addons and navigational results.