1894575 - SelectTranslationsPanel glitches when resized below the bottom screen boundary

Status: VERIFIED FIXED

(Firefox :: Translations, defect, P3)

Description

[Erik Nordin [:nordzilla]]

Description

I do not believe that the XUL panels were originally designed to be dynamically resized by click-and-dragging the mouse. As such, when the SelectTranslationsPanel allows for this case, some glitchy behavior occurs once the panel is resized below the bottom edge of the screen boundary.

We should disallow this situation for the SelectTranslationsPanel.

---

Steps to Reproduce

• Open a page and highlight all of the text.
• Open the SelectTranslationsPanel via the right-click context menu, near to the lower-middle portion of the page.
• Drag the textarea resizer down such that the bottom of the panel is dragged below the bottom of the screen.

Expected Behavior
The panel is not allowed to be resized that far, and stops before the bottom edge of the screen.

Actual behavior
The panel is dragged below the bottom of the screen, causing various glitchy behaviors that differ for each operating system.

---

Steps to implement

• Calculate the max-height for the panel based on the screen boundaries, and impose a maximum height such that this case is not encountered.

---

Tests to implement

• This is very hard to test in automation, as it involves clicking and dragging with the mouse.

Comment 1

[Erik Nordin [:nordzilla]]

Attachment: Bug 1894575 - Ensure panel cannot be resized off screen r=#translations-reviewers!

Depends on D209140

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1890490

Comment 3

[Haik Aftandilian [:haik]]

@Erik, is this expected to make 127?

Comment 4

[Greg Tatum [:gregtatum]]

This won't make the soft freeze. I'll leave the NI in case he is considering an uplift.

Comment 5

[Erik Nordin [:nordzilla]]

Sorry, I was out on PTO for the past week.

Unfortunately, due to me being gone, I did not have time to fix this before soft freeze.

There are some particular issues on Wayland (Bug 1895036) that have prevented this from landing as-is.

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1890490

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e1c35df380bc
Ensure panel cannot be resized off screen r=translations-reviewers,gregtatum

Comment 8

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/e1c35df380bc

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:nordzilla, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox127 to wontfix.

For more information, please visit BugBot documentation.

Comment 10

[Erik Nordin [:nordzilla]]

This does not need to be uplifted. The target release is now 128, and the panel is preffed off by default in 127 release build.

Comment 11

[Daniel Bodea [:danibodea]]

This issue no longer occurs in Nightly v128.0a1 in Windows10, MacOS11 or Ubuntu22 (both wayland or X11 Window Protocols). Resizing the dialog to the bottom of the screen no longer shows any glitchy behavior because the resizing is blocked before the bottom of the screen or if the translated text fits inside the textbox.