1896244 - When "Open new tab" or "Open new window" is executed from taskbutton of browser window, tabs of last closed normal window are unexpectedly restored.

Status: ASSIGNED

(Firefox :: Session Restore, defect, P2)

Description

[Alice0775 White]

Steps to reproduce:

1. Open Firefox with new profile(Open previous windows and tabs is disabled by default)

2. Open multiple websites in tabs

3. Close All Firefox window

4. Start Firefox in private browsing mode

5. Right click on the taskbutton. And choose "Open new tab" or "Open new window"

Actual Results:
Tabs of last closed normal window at step 2 are unexpectedly restored.

Expected Results:
Should not restored any last closed tab.

Comment 1

[Alice0775 White]

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=df74c724a47d95ff0e380c5ba587c03a25ddd93d&tochange=8737a1c1bc55e77b43e7c6daab1f7882a0b38ce7

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

:sclements, since you are the author of the regressor, bug 1820660, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 5

[Sarah Clements [:sclements]]

Thanks for finding the regressing bug. I'll start on this once I wrap up the current patch I'm in the middle of.

Comment 6

[Liz Henry (:lizzard) (relman/hg->git project)]

Sarah, are you still intending to work on this? Or, can you help find another owner? Thanks!

Comment 7

[Sarah Clements [:sclements]]

(In reply to Liz Henry (:lizzard) (relman/hg->git project) from comment #6)

Sarah, are you still intending to work on this? Or, can you help find another owner? Thanks!

I am still intending to work on it soon but also I realized its marked as an S2 which I don't think is accurate - there isn't any data loss here, more of an unexpected scenerio.

Comment 8

[TechHorse]

"I realized its marked as an S2 which I don't think is accurate - there isn't any data loss here, more of an unexpected scenerio."

I hope that I am not breaking any etiquette here but I would have to disagree with the severity or the notion of no data loss.

This bug can potentially spell trouble for some users. For example some websites forbid the use of their services while a connected VPN is running. This means that a user might violate the TOS of their account if, through no fault of their own, the website loads while their VPN is connected.

Plus there can always be privacy issues when websites from a previous session appear unexpectedly.

Comment 11

[Justin]

Why wont this be fixed?
It is a regression.
It is totally unexpected behavior.
It could cause privacy issues (as previously stated).
Several people took the time to report it, so it is perceived as a bug and/or undesirable behavior.
Why won't this be fixed?

Comment 12

[Sarah Clements [:sclements]]

(In reply to Justin from comment #11)

Why wont this be fixed?
It is a regression.
It is totally unexpected behavior.
It could cause privacy issues (as previously stated).
Several people took the time to report it, so it is perceived as a bug and/or undesirable behavior.
Why won't this be fixed?

It will be fixed but the engineers who maintain session restore code (including myself) are short staffed and work on other projects which have a higher priority.