1900916 - If navigating to the next unread message expands the thread, the scroll position is wrong

Status: VERIFIED FIXED

(Thunderbird :: Folder and Message Lists, defect)

Description

[Geoff Lankow (:darktrojan) [PTO, back 2 Nov]]

With the newest messages at the bottom, if I go to the next unread message (N or T key) and it's in a thread which needs to be expanded, the thread is expanded and the first unread message is selected. But if there are more messages in the thread below the selected one, they are below the bottom of the list and I can't see them. This happens even if the whole expanded thread could fit on the screen.

If there's too many new messages in the thread to show them all, I think the selected message should be at the top with as many newer messages visible below it as possible. Otherwise all of the new messages should be visible with the last one at the bottom of the list.

This may be a regression from bug 1862197, I'm not sure. It seems to be annoying me more in the last week or so on 127 beta, so maybe something else changed the behaviour. Hartmut can you have a look at this please?

Comment 1

[Hartmut Welpmann [:welpy-cw]]

(In reply to Geoff Lankow (:darktrojan) from comment #0)

This may be a regression from bug 1862197, I'm not sure. It seems to be annoying me more in the last week or so on 127 beta, so maybe something else changed the behaviour. Hartmut can you have a look at this please?

I don't think that has been working in a better way since 115, but after a little refactoring, this seems to be an easy fix.

Comment 2

[Hartmut Welpmann [:welpy-cw]]

Attachment: Bug 1900916 - Scroll an expanded thread to the most useful position also when navigating. r=darktrojan

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/d7bd3c172cad
Scroll an expanded thread to the most useful position also when navigating. r=darktrojan

Comment 4

[Geoff Lankow (:darktrojan) [PTO, back 2 Nov]]

Comment on attachment 9406980 [details]
Bug 1900916 - Scroll an expanded thread to the most useful position also when navigating. r=darktrojan

[Approval Request Comment]
Regression caused by (bug #): supernova, I think
User impact if declined: expanding threads in some circumstances doesn't show as much of the thread as possible
Testing completed (on c-c, etc.): 9 days on c-c
Risk to taking this patch (and alternatives if risky): low

Comment 5

[Corey Bryant]

Comment on attachment 9406980 [details]
Bug 1900916 - Scroll an expanded thread to the most useful position also when navigating. r=darktrojan

[Triage Comment]
Approved for beta

Comment 6

[Rob Lemley [:rjl]]

Thunderbird 128.0b4:
https://hg.mozilla.org/releases/comm-beta/rev/29c7c770385f

Comment 7

[Vlad Lucaci, Thunderbird QA (:vlucaci)]

Managed to reproduce this issue using the affected build from 2024-06-05(20240605103015).

Confirming this issue as verified fixed on 128.0b4(20240624182435) on Windows 11, macOS 14 and Ubuntu 22.