1901705 - Dead code removal

Status: ASSIGNED

(Thunderbird :: General, task)

Description

[Geoff Lankow (:darktrojan)]

Closing the old bug 1851535 and starting a new bug for post-128 work.

Code coverage data has revealed some chunks of dead code. Unsurprising given how much we've rebuilt in the past few years. I'll use this bug to remove the dead code as I find it. This will probably be an ongoing effort for a number of months.

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1901705 - Remove MessengerProfileMigrator. r=#thunderbird-reviewers

Comment 2

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1901705 - Remove actionsshared.js. r=#thunderbird-reviewers

I can't find when this file was last used. It was before v60.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/920e10d56434
Remove actionsshared.js. r=mkmelin

Comment 4

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1901705 - Remove migrations that have shipped in at least three ESRs. r=#thunderbird-reviewers

These migrations have been in version 102, 115, and now 128.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/2a452706b67f
Remove migrations that have shipped in at least three ESRs. r=aleca

Comment 6

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1901705 - Remove mailnews/db/moz.build. r=#thunderbird-reviewers

This file doesn't do anything, it's not included in the parent directory's moz.build.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/e4275ad7e918
Remove mailnews/db/moz.build. r=aleca

Comment 8

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1901705 - Remove obsolete pref extensions.overlayloader.loglevel. r=#thunderbird-reviewers

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/0d8216d3998d
Remove obsolete pref extensions.overlayloader.loglevel. r=john.bieling

Comment 10

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1901705 - Remove dead nsMsgAccountManager::GetSortOrder. r=#thunderbird-reviewers

This was last used in an old account order migration we no longer have.

Comment 11

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1901705 - Remove dead MSGApopMD5. r=#thunderbird-reviewers

This hasn't been used since POP3 was rewritten.

Comment 12

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1901705 - Remove dead NS_GetUnicharPreferenceWithDefault. r=#thunderbird-reviewers

This hasn't been used since the compose service was rewritten.

Comment 13

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1901705 - Remove dead MsgGetLocalFileFromURI. r=#thunderbird-reviewers

This hasn't been used since before ESR60.

Comment 14

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1901705 - Remove dead MsgAdvanceToNextLine. r=#thunderbird-reviewers

This hasn't been used since bug 1719121 rewrote From-line handling.

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/21231fe7efd9
Remove dead MSGApopMD5. r=BenC
https://hg.mozilla.org/comm-central/rev/bfaea9984222
Remove dead NS_GetUnicharPreferenceWithDefault. r=BenC
https://hg.mozilla.org/comm-central/rev/c531d2dadcb2
Remove dead MsgGetLocalFileFromURI. r=BenC
https://hg.mozilla.org/comm-central/rev/ff3335f1be70
Remove dead MsgAdvanceToNextLine. r=BenC

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/479a305a3157
Remove dead nsMsgAccountManager::GetSortOrder. r=aleca

Comment 17

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1901705 - Remove dead functions in nsMsgKeySet. r=#thunderbird-reviewers

These functions are unused.

Comment 18

[John Bieling (:TbSync)]

Attachment: Bug 1901705 - Remove obsolete test_addon_prefs test. r=darktrojan

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/db50925a5ffd
Remove dead functions in nsMsgKeySet. r=mkmelin

Comment 20

[Hartmut Welpmann [:welpy-cw]]

Attachment: Bug 1901705 - Remove obsolete code in ComposeStartup(). r=#thunderbird-reviewers

Apparently this has been decaying for more than 16 years ...

Comment 21

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/a9b4203d91cc
Remove obsolete test_addon_prefs test. r=mkmelin

Comment 22

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1901705 - Remove nsIMsgIncomingServer.sortOrder. r=#thunderbird-reviewers

Comment 23

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/5eabeb5b729f
Remove nsIMsgIncomingServer.sortOrder. r=aleca