1970022 - Dead code removal

Status: REOPENED

(Thunderbird :: General, task)

Description

[Geoff Lankow (:darktrojan) [OOO, back 7 Apr]]

Like bug 1901705 and bug 1851535, but for work after ESR 140.

Please don't use this bug to post your own patches, it just makes things more confusing.

Comment 1

[Geoff Lankow (:darktrojan) [OOO, back 7 Apr]]

Attachment: Bug 1970022 - Remove things from nsIMsgAccountManager that don't need to be there. r=#thunderbird-reviewers

There's some dead functions and a bunch of properties that can be called directly and don't need to be in the interface.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/af1405fb055a
Remove things from nsIMsgAccountManager that don't need to be there. r=mkmelin

Comment 3

[Geoff Lankow (:darktrojan) [OOO, back 7 Apr]]

Oh look at that, I knew there was something else I had to do.

Comment 4

[Geoff Lankow (:darktrojan) [OOO, back 7 Apr]]

Attachment: Bug 1970022 - Remove zombie test files in comm_taskgraph. r=#thunderbird-reviewers

These files were removed in https://hg.mozilla.org/comm-central/rev/7393ec9170ba6795b79cfaabe71267ea8fa79329,
but accidentally came back from the dead in https://hg.mozilla.org/comm-central/rev/aeeb306cd1a94e5c36a3f62e6589001e9224a0b6.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/d6e0dd04c35f
Remove zombie test files in comm_taskgraph. r=freaktechnik

Comment 6

[Geoff Lankow (:darktrojan) [OOO, back 7 Apr]]

Attachment: Bug 1970022 - Remove nsIMessengerMigrator. r=#thunderbird-reviewers

This hasn't been used for anything since we removed the C++ NNTP implementation.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/5fe0c65a4e35
Remove nsIMessengerMigrator. r=mkmelin

Comment 8

[Geoff Lankow (:darktrojan) [OOO, back 7 Apr]]

Attachment: Bug 1970022 - Remove some unused code in message views. r=#thunderbird-reviewers

These things have been around since before comm-central existed, and I don't think they've been
connected to anything.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/28e14b33aa53
Remove some unused code in message views. r=aleca

Comment 10

[Geoff Lankow (:darktrojan) [OOO, back 7 Apr]]

Attachment: Bug 1970022 - Remove mailnews/import/build. r=#thunderbird-reviewers

This folder does nothing useful.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/b3dce803e2df
Remove mailnews/import/build. r=aleca

Comment 12

[Geoff Lankow (:darktrojan) [OOO, back 7 Apr]]

Attachment: Bug 1970022 - Remove Gloda .project file. r=#thunderbird-reviewers

This appears to be an Eclipse file that should never have been committed (it's listed in .hgignore).

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/d1c4ddce79ff
Remove Gloda .project file. r=aleca

Comment 14

[Geoff Lankow (:darktrojan) [OOO, back 7 Apr]]

Attachment: Bug 1970022 - Move the used parts of GetFolderURIFromUserPrefs to the only caller. r=#thunderbird-back-end-reviewers

There's a single caller of this function, and it doesn't use much of the code.

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/468f1ff3d84d
Move the used parts of GetFolderURIFromUserPrefs to the only caller. r=mkmelin

Comment 16

[Geoff Lankow (:darktrojan) [OOO, back 7 Apr]]

Attachment: Bug 1970022 - Remove a bunch of dead CSS rules for XUL trees. r=freaktechnik

Comment 17

[Geoff Lankow (:darktrojan) [OOO, back 7 Apr]]

Attachment: Bug 1970022 - Remove unused implementation of nsITransportEventSink in nsMsgProtocol. r=#thunderbird-reviewers

I removed the only reference to this in bug 1851535.

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/fd6761300e00
Remove unused implementation of nsITransportEventSink in nsMsgProtocol. r=mkmelin

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/0628d20688a3
Remove a bunch of dead CSS rules for XUL trees. r=freaktechnik

Comment 20

[Geoff Lankow (:darktrojan) [OOO, back 7 Apr]]

Attachment: Bug 1970022 - Remove migrateCalendarUI. r=#thunderbird-reviewers

The last change using this code was in 2016. I think it's safe to remove now.

Comment 21

[Geoff Lankow (:darktrojan) [OOO, back 7 Apr]]

Attachment: Bug 1970022 - Remove tasksCommands and tasksKeys. r=#thunderbird-reviewers

These commands and keys are scattered around the code and it doesn't make a lot of sense.

Comment 22

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/c2c57f4911fc
Remove migrateCalendarUI. r=mkmelin
https://hg.mozilla.org/comm-central/rev/9f1d34e064e6
Remove tasksCommands and tasksKeys. r=mkmelin

Comment 23

[Geoff Lankow (:darktrojan) [OOO, back 7 Apr]]

Attachment: Bug 1970022 - Refactor away unnecessary enumeration. r=BenC

Comment 24

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/3ce7f6d15038
Refactor away unnecessary enumeration. r=BenC

Comment 25

[Geoff Lankow (:darktrojan) [OOO, back 7 Apr]]

Attachment: Bug 1970022 - Remove dead CalDavCalendar.oauthConnect. r=#thunderbird-reviewers.

This hasn't been called since bug 1546606, almost 6 years ago.

Comment 26

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/e1cb57e6cf37
Remove dead CalDavCalendar.oauthConnect. r=mkmelin