1901826 - Fullscreen toolbar autohides prematurely when tab preview disappears

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect, P2)

Description

[Joel Viking]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:129.0) Gecko/20100101 Firefox/129.0

Steps to reproduce:

Nightly.
When in full screen hovering a tab with the curosr and then lowering the cursor to the toolbar, the toolbar continues to fullscreen without any means to hit the toobar with the cursor. Except if your hovering anything else besides the tabs to the left and right, then the expected behaviour happens.

Actual results:

In full screen changing tabs and the going for the toolbar. Not being able to klick the toolbar below.

Expected results:

One should be able to klick the toolbar

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Session Restore' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Patrick (he/him)]

Hi, thanks for reporting this issue. I haven't been able to reproduce it, would you able to provide some screenshots or a screen recording?

Comment 3

[Joel Viking]

Well in hindsight, i see that i misspoke, it is the web address part of the toolbar that i can´t hit.

Comment 4

[Joel Viking]

Attachment: Fullscreen_behavior_inconsistent.mp4

This shows the inconsistent behaviour of working tabs in fullscreen.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:dao, could you have a look please?

For more information, please visit BugBot documentation.

Comment 6

[Daniel Bodea [:danibodea]]

I can reproduce this issue with Nightly v129.0a1, but not with Beta v128.0 (RC) on Windows 10. I am confirming the report. Thank you!

Comment 7

[Dão Gottwald [:dao]]

DJ, could you please triage this?

Comment 8

[Kestrel]

Fullscreen toolbar autohide has been broken by the tab previews since browser.tabs.cardPreview.enabled = true. The toolbar autohides prematurely when the tab preview disappears, making it harder to access the navigation toolbar. The user needs to quickly move the cursor below the tabs before the tab preview appears to avoid it autohiding.

Comment 9

[DJ (:dwalker)]

Attachment: Bug 1901826 - prevent tab preview from triggering fullscreen toolbar autohide. r?dao

Comment 10

[Chris Peterson [:cpeterson]]

Jeremy recommends that we uplift this fix because it prevents the user from clicking focus to the address bar in fullscreen mode.

Comment 12

[Mike Squire]

In response to Marco's question in bug 1914079:

In the meanwhile, I assume if you temporarily disable the "Show a preview when hovering a tab" checkbox in General Preferences, the behavior goes back to normal (no bug)?

Dão was correct, this does not mitigate the bug.

However there is a workaround until the fix is rolled out. If you set "browser.tabs.hoverPreview.enabled" to false in about:config the white preview boxes are replaced by black tooltips which just contain the title of the tab and this bug does not manifest.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/35f2d2698b1a
prevent tab preview from triggering fullscreen toolbar autohide. r=dao,jswinarton

Comment 14

[Atila Butkovits]

Backed out for causing failures at browser_fullscreen_tab_preview.js.

Backout link: https://hg.mozilla.org/integration/autoland/rev/7747c74fffcf7471f460ba99b3dd6bab654470ca

Push where failures started: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=8312c5570b7e993c323f0b47a42338b61b6daee2&selectedTaskRun=R_KKIlf9SsC-beu_Y6wLsw.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=473565741&repo=autoland&lineNumber=2538

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0fab45288998
prevent tab preview from triggering fullscreen toolbar autohide. r=dao,jswinarton

Comment 16

[Sandor Molnar[:smolnar]]

Backed out for causing bc perma failures @ browser_fullscreen_tab_preview.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/d3da403b9d5a66429ea665e15b0a4124bd91c634

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | browser/base/content/test/fullscreen/browser_fullscreen_tab_preview.js | Test timed out

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ceb7a7e46f59
prevent tab preview from triggering fullscreen toolbar autohide. r=dao,jswinarton

Comment 18

[Norisz Fay [:noriszfay]]

Backed out for causing bc failures on browser_fullscreen_tab_preview.js

Backout link

Push with failures

Failure log

Comment 21

[Dianna Smith [:diannaS]]

:dwalker marking this as fix-optional since we enabled this feature in 131. Will there possibly be a fix for 132?

Comment 23

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1893676

Comment 24

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4d5d609a0038
prevent tab preview from triggering fullscreen toolbar autohide. r=dao,jswinarton

Comment 25

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/4d5d609a0038

Comment 26

[Ryan VanderMeulen [:RyanVM]]

Please nominate this for Beta approval when you get a chance.

Comment 28

[DJ (:dwalker)]

Attachment: Bug 1901826 - prevent tab preview from triggering fullscreen toolbar autohide. r?dao

Original Revision: https://phabricator.services.mozilla.com/D218432

Comment 29

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: the associated bug will persist in Fx132
• Code covered by automated testing: yes
• Fix verified in Nightly: no
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: set 'browser.fullscreen.autohide' to true, enter fullscreen, and open a tab preview. When moving the mouse off the tab strip the preview should disappear but the nav toolbox should remain.
• Risk associated with taking this patch: low
• Explanation of risk level: one-line change with narrow scope
• String changes made/needed: none
• Is Android affected?: no

Comment 30

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/2e9e5e141cfc

Comment 31

[Bianca Hidecuti, Desktop Test Engineering [:bhidecuti]]

Reproduced the issue on Firefox 132.0b7, using Windows 11, as described in Comment 29.
Verified as fixed using Firefox Nightly 133.0a1 (2024-10-15) and Firefox 132.0b8 (treeherder build - Comment 30), on Windows 11, macOS 14.7 and Ubuntu 22.04. When moving the mouse off the tab strip (to the toolbar) the preview disappears but the nav toolbox remains.