1905708 - Restoring import tab that was in profile import flow restores broken tab

Status: VERIFIED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Martin Giger [:freaktechnik]]

STR:

• Open an import tab
• Select import profile from TB or SM and click next
• Close Thunderbird
• Open Thunderbird again

Expected result:
A usable import tab is restored (likely the first step in the flow).

Actual result:
A broken import tab is restored, showing multiple steps.

Comment 1

[Martin Giger [:freaktechnik]]

Attachment: Bug 1905708 - Fix restoring profile import tab. r=#thunderbird-front-end-reviewers

Comment 2

[Martin Giger [:freaktechnik]]

Attachment: Bug 1905708 - Fix restoring profile import tab. r=#thunderbird-front-end-reviewers

Comment 3

[Martin Giger [:freaktechnik]]

Attachment: Bug 1905708 - Fix restoring profile import tab. r=#thunderbird-front-end-reviewers

Comment 4

[Martin Giger [:freaktechnik]]

Attachment: Bug 1905708 - Fix restoring profile import tab. r=#thunderbird-front-end-reviewers

Comment 5

[Martin Giger [:freaktechnik]]

Attachment: Bug 1905708 - Fix restoring profile import tab. r=#thunderbird-front-end-reviewers

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/78b6e8d87b68
Fix restoring profile import tab. r=vineet,arschmitz

Comment 7

[Martin Giger [:freaktechnik]]

Comment on attachment 9410592 [details]
Bug 1905708 - Fix restoring profile import tab. r=#thunderbird-front-end-reviewers

[Approval Request Comment]
Regression caused by (bug #): Bug 1904305
User impact if declined: When closing thunderbird with an import tab in the profile flow it will get restored in a broken state.
Testing completed (on c-c, etc.): Manually tested on c-c, now on c-b. Patch also has new automated tests.
Risk to taking this patch (and alternatives if risky): Low risk, alternative is that users just need to close the broken tab and everything will be fine.

Comment 8

[Wayne Mery (:wsmwk)]

Comment on attachment 9410592 [details]
Bug 1905708 - Fix restoring profile import tab. r=#thunderbird-front-end-reviewers

[Triage Comment]
Approved for esr128

Comment 9

[Daniel Darnell [:dandarnell]]

Thunderbird 128.0.1esr:
https://hg.mozilla.org/releases/comm-esr128/rev/d8fd748e420a

Comment 10

[Ramona Gavrilescu]

Confirming this issue as verified fixed for 128.0.1esr(20240717233102) Win10&11 and macOS 14.