1904305 - import tab doesn't activate if export is shown (and vice versa)

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Magnus Melin [:mkmelin]]

Can't go to Export if you already opened the Import tab. Can't go to Import if you have the Export tab open.
This used to work in Thunderbird 115.

STR:
Go to: Tools | Import -- the import tab opens.
Leave the import tab open.
Go to: Tools | Export -- now does nothing.

Comment 1

[Magnus Melin [:mkmelin]]

We get at least as far as https://searchfox.org/comm-central/rev/beb138c6528bea20ec64663c05157fa6be2b1579/mail/base/content/mailCore.js#533 for both.

Comment 2

[Ramona Gavrilescu]

Managed to reproduce this on TB 128.0b4(20240624182435) with macOS14.
Tested on 127.0b5(20240603175044) and it does not reproduce.

Comment 3

[Martin Giger [:freaktechnik]]

Regression range: https://hg.mozilla.org/comm-central/pushloghtml?fromchange=4d3088c028a68b68cd500815bf0b98ff88e55fd0&tochange=f7b808f9627914d04f5fd4ad21f642a0c5772148

Just to document the old behavior: the contents of the tab used to get replaced in the existing import/export tab.

Comment 4

[Martin Giger [:freaktechnik]]

Attachment: Bug 1904305 - Fix switching import tab contents from external entrypoints. r=#thunderbird-front-end-reviewers

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/6ec176163893
Fix switching import tab contents from external entrypoints. r=aleca

Comment 6

[Martin Giger [:freaktechnik]]

Comment on attachment 9409971 [details]
Bug 1904305 - Fix switching import tab contents from external entrypoints. r=#thunderbird-front-end-reviewers

[Approval Request Comment]
Regression caused by (bug #):
User impact if declined: Can't open export if import is open and vice-versa. Also, various import entrypoints will behave weirdly.
Testing completed (on c-c, etc.): Tested on c-c, new automated test.
Risk to taking this patch (and alternatives if risky): There is some risk, where it would break the import/export page.

Comment 7

[Corey Bryant]

Comment on attachment 9409971 [details]
Bug 1904305 - Fix switching import tab contents from external entrypoints. r=#thunderbird-front-end-reviewers

[Triage Comment]
Approved for beta

Comment 8

[Rob Lemley [:rjl]]

Thunderbird 128.0b6:
https://hg.mozilla.org/releases/comm-beta/rev/a21f28bed1fd