1906795 - [toolbar redesign] support landscape mode for redesigned custom tab

Status: RESOLVED FIXED

(Fenix :: Toolbar, task, P1)

Description

[Mike a [:mavduevskiy]]

updated design here:
https://www.figma.com/design/8fsCvtnweBkWGZ9NfL907l/Toolbar-Redesign?node-id=5728-319562&t=0AxmRxHZs3CXilYB-4

Comment 1

[Joe M [:jmahon]]

Possible options:

• add navigation buttons (close, forward, backward), "open in browser" button, and "menu" button to Custom Tab landscape layout
• or, we could disable redesign for custom tabs. We'd need to discuss this with PM and Design (it would only last until Phase 2, when it would then be corrected).

To be determined: which is the simplest solution?

(we will come back to this later)

Alternative that we rejected:

• We could avoid doing it, but we'd then need to show the nav bar with the custom toolbar (this doesn't make sense; it would take to much viewport space)

Comment 2

[Joe M [:jmahon]]

Planning poker notes:

• we already show nav bar on portrait phones for custom tabs, so we should be able to reuse most of that for landscape

Comment 3

[Chris Peterson [:cpeterson]]

Increasing priority to P1 now that we're fixing toolbar phase 1's beta blockers.

Comment 4

[Joe M [:jmahon]]

Note: Not expected to land before Tuesday 8/6. We may want to somehow capture what portion will get done by then.

Comment 7

[Mike a [:mavduevskiy]]

Soft-blocked by 1910242: both bugs deal with a configuration change, and in 1910242 we will be coming up with an architecture decision how to propagate the change into the components layer.

Comment 9

[Joe M [:jmahon]]

Note from convo with Mike: he'll leave a comment here describing more about what still needs to get done for this ticket. It also might need to get pulled into the current banana sprint - he'll coordinate with the squad on Slack to figure that out.

Comment 10

[Mike a [:mavduevskiy]]

As of now, need to add tests for CustomTabsIntegration that is responsible for adding/removing buttons on rotation. I expect to finish it tomorrow.

Comment 11

[Mike a [:mavduevskiy]]

Attachment: Bug 1906795 – Implement new landscape design for custom tabs

With the addition of the navigation bar in the portrait mode, we are changing the UI on rotation: mainly, buttons, that were part of the navigation bar, are being added to the toolbar instead, to save space.

This patch is adding navigation, share, menu and open in firefox as actions to the toolbar.

Comment 12

[Mike a [:mavduevskiy]]

Attachment: Bug 1906795 – Add a ColourUtils function to calculate alpha from opacity

Comment 14

[Mike a [:mavduevskiy]]

Attachment: Bug 1906795 – Refactor !! usage in accessing drawables in CustomTabsIntegration

Comment 15

[[:skhan]]

Attachment: Extra_share_button_in_landscape.mp4

Added this as a comment on the patch. Adding here for more visibility and easy tracking.

Hey Mike. Thanks for all the great work! I've skimmed through the comments and I am hoping I don't replicate any comment that is already in the process of getting fixed.

I've found you've 'manually' added a share button to toolbar which we shouldn't. This was discussed sometime back in the project meetings and in the menu channel in case you missed.
We will only be adding share button to toolbar if it is passed in the CustomTabConfig through the external(or internal) app intent. Our own share button will only reside as a menu item. I am attaching video and screenshots to show what this might lead to.
Custom Tab in Private mode showing two share buttons
Custom tab in Normal mode No share button in portrait but one in landscape

Comment 16

[[:skhan]]

Attachment: Two_share_buttons_private_theme.png

Comment 17

[[:skhan]]

The confusion could have arisen because figma was never updated back then. I asked our UX engineers now and they updated it. Cheers.
Also led to a discovery of one more task. We should be adding the share button not just in the old menu but also for new menu (Menu Redesign)

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/389e4b1ddc9e
– Add a ColourUtils function to calculate alpha from opacity r=android-reviewers,harrisono
https://hg.mozilla.org/integration/autoland/rev/40833555896a
– Implement new landscape design for custom tabs r=android-reviewers,skhan,twhite
https://hg.mozilla.org/integration/autoland/rev/f5d37649f886
– Refactor !! usage in accessing drawables in CustomTabsIntegration r=android-reviewers,pollymce

Comment 19

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/389e4b1ddc9e
https://hg.mozilla.org/mozilla-central/rev/40833555896a
https://hg.mozilla.org/mozilla-central/rev/f5d37649f886

Comment 20

[Delia Pop]

Hi Mike, we noticed that the Navigation buttons, the Reload button and the "Open in Firefox" button
are still not displayed in the latest Nightly 133.0a1 from 10/16 on tablet devices.
Since I wasn’t sure if this is handled in another ticket, I filed a new one, 1925050.