1908409 - API to close & save group

Status: RESOLVED DUPLICATE of bug 1923652

(Firefox :: Tabbed Browser, task, P1)

Description

[Dão Gottwald [:dao]]

Figma: https://www.figma.com/design/f6J2lH6XDxLxyzOLr2E8oE/Tab-Grouping?node-id=8113-150507&t=yIMA80oXn1yJy1MA-0

Comment 1

[Stephen Thompson [:sthompson]]

https://bugzilla.mozilla.org/show_bug.cgi?id=1908411 created an API to remove a tab group https://searchfox.org/mozilla-central/source/browser/components/tabbrowser/content/tabbrowser.js#2969-2974

Since tab groups are always going to be "saved," I don't think we need a new API method. Do we?

It is possible that the current implementation (call removeTabs() on all tabs in the group, implicitly removing the group with the closure of the last tab in the group) may not interact well with our goals for saving closed groups, e.g https://bugzilla.mozilla.org/show_bug.cgi?id=1908422. But if that is the case, then I would recommend that we close this bug and track any necessary changes for session restore purposes in the session restore component.

Comment 2

[Dão Gottwald [:dao]]

(In reply to Stephen Thompson from comment #1)

https://bugzilla.mozilla.org/show_bug.cgi?id=1908411 created an API to remove a tab group https://searchfox.org/mozilla-central/source/browser/components/tabbrowser/content/tabbrowser.js#2969-2974

Since tab groups are always going to be "saved," I don't think we need a new API method. Do we?

A group can be deleted, in which case it won't be saved (only temporarily for the "recently closed" menu). So yeah, we need two methods here on the tabbrowser side, that in some way communicate to sessionstore what to do with the group.

Comment 3

[DJ (:dwalker)]

Noting a comment from a different patch here about implementing a _LAST_ACTION_CLOSED_TAB_GROUP; I think it makes sense to include that here.

Comment 4

[DJ (:dwalker)]

Group saving was already implemented in SessionStore; behavior has been wired up in the referenced bug