1921802 - Automatically save groups when closing the window they're open in

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, task, P1)

Description

[Dão Gottwald [:dao]]

When closing a window, we need to save its groups rather than deleting them.

Comment 1

[Stephen Thompson [:sthompson]]

Would be helpful to build on saved group API additions from bug 1933114

Comment 2

[Stephen Thompson [:sthompson]]

Attachment: Bug 1921802 - save open tab groups on window close r=dao,dwalker,jswinarton

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2817415422a2
save open tab groups on window close r=dao,sessionstore-reviewers

Comment 4

[amarc]

Backed out for causing bc failures @ browser_1933485_tab_groups_history.js

• Backout link
• Push with failures
• Failure Log
• Failure line:

TEST-UNEXPECTED-FAIL | browser/components/sessionstore/test/browser_1933485_tab_groups_history.js | Tab group is stored in closedGroups - 0 == 1 -

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/058542c2a378
save open tab groups on window close r=dao,sessionstore-reviewers

Comment 6

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/058542c2a378

Comment 7

[Stephen Thompson [:sthompson]]

I resolved the bad test issue with the last patch that landed.