1908423 - Implement savedGroups array

Status: RESOLVED FIXED

(Firefox :: Session Restore, task, P2)

Description

[Dão Gottwald [:dao]]

The top level gains a savedGroups array. When hidden, groups are moved here and their tabs moved to a tabs array property on the group.

Comment 1

[Stephen Thompson]

What is the intended difference between the top-level savedGroups and the per-window _closedGroups https://bugzilla.mozilla.org/show_bug.cgi?id=1908422?

When hidden, groups are moved here

Does "hiding" a group mean collapsing the group? I didn't think so -- I thought that a collapsed tab group still appears in the per-window groups, its tabs continue to appear in the per-window tabs, and the tabs in the group retain their groupId properties.

Is there no longer any "hidden" state for a tab group? Do we just need to account for closed tab groups?

Comment 2

[Dão Gottwald [:dao]]

(In reply to Stephen Thompson from comment #1)

What is the intended difference between the top-level savedGroups and the per-window _closedGroups https://bugzilla.mozilla.org/show_bug.cgi?id=1908422?

The latter is for "deleted" groups (that can be reopened like closed tabs).

When hidden, groups are moved here

Does "hiding" a group mean collapsing the group? I didn't think so -- I thought that a collapsed tab group still appears in the per-window groups, its tabs continue to appear in the per-window tabs, and the tabs in the group retain their groupId properties.

Is there no longer any "hidden" state for a tab group? Do we just need to account for closed tab groups?

Sorry, terminology changed a few times. "hidden" means closed & saved here.

Comment 3

[Jeremy Swinarton]

Attachment: Bug 1908423: Add savedGroups to SessionRestore for tab groups r?dao,dwalker,sthompson

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/62d15031a31d
Add savedGroups to SessionRestore for tab groups r=dao,sessionstore-reviewers

Comment 5

[Serban Stanca [:SerbanS]]

Backed out for causing mochitests failures browser_tab_groups_saved.js.

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | browser/components/sessionstore/test/browser_tab_groups_saved.js | Uncaught exception in test bound test_SaveTabGroups - at chrome://browser/content/tabbrowser/tabbrowser.js:5461 - TypeError: Node.appendChild: Argument 1 is not an object.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1c3919d8e867
Add savedGroups to SessionRestore for tab groups r=dao,sessionstore-reviewers

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/1c3919d8e867