1908620 - [Toolbar redesign] FindInPage bar hidden by navbar

Status: VERIFIED FIXED

(Fenix :: Toolbar, defect, P1)

Description

[Petru-Mugurel Lingurar [:petru]]

Attachment: NavbarShownOverFindInBarPageBar.mp4

Seems like only the address bar is hidden while searching in page
And after searching ends the navbar is not expanded also.

Comment 1

[Petru-Mugurel Lingurar [:petru]]

Attachment: FindInPageBarExpectedBehavior.mp4

The toolbar (addressbar + navbar) should be hidden when the searching in page
And should be fully expanded after searching has ended.

Comment 4

[Denis Müller [:Webworkr]]

(In reply to Petru-Mugurel Lingurar [:petru] from comment #0)
[...]

And after searching ends the navbar is not expanded also.

This covers the content of the report from Bug 1907499 "'Find in page' closes when navigating results"?

Comment 5

[Petru-Mugurel Lingurar [:petru]]

(In reply to Denis Müller [:Webworkr] from comment #4)

(In reply to Petru-Mugurel Lingurar [:petru] from comment #0)
[...]

And after searching ends the navbar is not expanded also.

This covers the content of the report from Bug 1907499 "'Find in page' closes when navigating results"?

Bug 1907499 seems to refer to my report of "Seems like only the address bar is hidden while searching in page".
As seen in my attached recording the "find in page bar" is not closed, it's just obscured by the navigation bar.
We are already hiding the address bar which otherwise would obscure it also, now we need to make sure of hiding the navigation bar also.

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The severity field for this bug is set to S3. However, the following bug duplicate has higher severity:

• Bug 1907905: S2

:royang, could you consider increasing the severity of this bug to S2?

For more information, please visit BugBot documentation.

Comment 8

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1908620 - Hide all toolbars when find in page is active r=#android-reviewers

When the find in page bar is active:

• all toolbars, no matter their configuration will be hidden
• the engine view will grow to cover all screen minus the find in page bar

When the find in page bar is closed:

• the toolbars are restored - they will be shown as before find in page
• the engine view will be restored to the configuration from before find in page

Comment 9

[Mike a [:mavduevskiy]]

Nice work, Petru! I am looking forward to this patch :)

One extra thing we should consider is adjusting setDynamicToolbarMaxHeight when toolbars change their visibility. Probably, we want something like: put content on top of the FindInPage search button and later put it back on top of the browser toolbars.

Awesome work!

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c7581a618d08
Hide all toolbars when find in page is active r=android-reviewers,skhan

Comment 14

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/c7581a618d08

Comment 15

[Donal Meehan [:dmeehan]]

:petru does this need a beta uplift request to fix it for Fx130?

Comment 16

[Petru-Mugurel Lingurar [:petru]]

This is an important issue but depends on using the navbar which is not available in Beta+ so not need to uplift.

Comment 17

[Delia Pop]

Attachment: FindInPage_Trim.mp4

This issue is partially fixed on the latest Nightly 131.0a1 from 08/09 with Xiaomi 12 Pro (Android 13), Google Pixel 8 Pro (Android 14) and OPPO A15s (Android 10) and Samsung Tab S8 Ultra 5G (Android 14).
The address bar is hidden when using the "Find in page" bar, but an additional issue occurs if the orientation is changed to Landscape/portrait mode:

• address bar positioned on Top: when changing the orientation to Landscape, the toolbar is displayed as a black space. This blank address bar remains displayed when rotating the device back to Portrait mode, and additionally the "Find in page" bar is again hidden under the navigation toolbar.
• address bar positioned on Bottom: when changing the orientation to Landscape, then back to Portrait mode, the "Find in page" bar is again hidden under the navigation toolbar.
  I'll file a separate ticket for this issue, and update this as verified.