1912484 - [Toolbar Redesign] The Find in page text bar is hidden by navigation bar after changing the device orientation or switching apps

Status: VERIFIED FIXED

(Fenix :: Toolbar, defect, P1)

Description

[Delia Pop]

Attachment: FindInPage_Trim.mp4

Steps to reproduce

1. Visit a webpage with text.
2. Tap the 3-dot menu button from the Navigation bar, and tap 'Find in Page'.
3. Enter a word to search (that exists in more than one place).
4. Tap the up and down buttons or tap anywhere on the screen to dismiss the keyboard.
5. Change the device orientation to Landscape mode, then change the orientation back to Portrait mode.
6. Observe the find in page text bar.

Expected behavior

The "Find in page" text bar remains shown when changing the orientation.
The Navigation toolbar and address bar are hidden.

Actual behavior

• with the address bar positioned on Top: when changing the orientation to Landscape, the toolbar is displayed as a black space. This blank address bar remains displayed when rotating the device back to Portrait mode, and additionally the "Find in page" bar is again hidden under the navigation toolbar.
• with the address bar positioned on Bottom: when changing the orientation to Landscape, then back to Portrait mode, the "Find in page" bar is hidden again under the navigation toolbar.

Device information

• Firefox version: Nightly 130.0a1 from 08/09
• Android device model: Google Pixel 8 Pro, any phone device
• Android OS version: Android 14

Additional information

Behavior observed while verifying 1908620.
This issue is also reproducible on PDFs and custom tabs.
Please note that this is not reproducible on tablets and I've also encountered a similar issue in 1912473.

Comment 1

[Petru-Mugurel Lingurar [:petru]]

This seems to depend on switching between showing addressbar + navbar or just the toolbar. We should

• update the padding for the find in page bar when the screen rotates or better yet
• avoid hardcoding a padding and ensure that the behavior responsable for positioning the find in page bar knows to always place it above any bottom toolbar shown / at the bottom when no such toolbar is shown.

Comment 2

[Kestrel]

It also happens when switching apps with the toolbar at the bottom and the find bar open with no change in orientation.

The address bar is missing and the navigation bar covers the find bar but it can still be moved out of the way by scrolling the page with the dynamic toolbar. Switching to a different tab corrects it.

Comment 3

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1912484 - part 1 - Don't update toolbar configurations while find in page is active r=#android-reviewers

When find in page is active all toolbars should be hidden.
Changing orientation would normally allow to update if the navbar should be shown or not
but while find in page is active there's no need for this.

Comment 4

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1912484 - part 2 - Don't show the bottom navbar after returning to app if find in page is active r=#android-reviewers

As an implementation detail - we start observing the search dialog state immediately as the app is visible
and depending on that state we might decide to show the navigation bar.
Avoid doing this while find in page is active - no other toolbar should be shown / updated.

Comment 5

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1912484 - part 3 - Have BrowserFragment handle restoring the layout after find in page ends r=#android-reviewers

One important scenario which would bring a lot of complexity to FindInPageIntegration:
Entering find in page with a specific device orientation then rotating the screen and closing
find in page while having another device orientation.
In this case the navbar might be show or not, something that is controlled from code inside of
BrowserFragment. Instead of duplicating that logic we'll leave BrowserFragment handle it.

Comment 6

[Petru-Mugurel Lingurar [:petru]]

(In reply to Kestrel from comment #2)

It also happens when switching apps with the toolbar at the bottom and the find bar open with no change in orientation.

The address bar is missing and the navigation bar covers the find bar but it can still be moved out of the way by scrolling the page with the dynamic toolbar. Switching to a different tab corrects it.

Thank you for the report!
Also saw this issue and added a patch to fix it (commit 2).

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:royang, could you have a look please?

For more information, please visit BugBot documentation.

Comment 8

[Petru-Mugurel Lingurar [:petru]]

Setting P1/S2 since this is already worked on.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8bbfc443032f
part 1 - Don't update toolbar configurations while find in page is active r=android-reviewers,skhan
https://hg.mozilla.org/integration/autoland/rev/968b90009ba4
part 2 - Don't show the bottom navbar after returning to app if find in page is active r=android-reviewers,skhan
https://hg.mozilla.org/integration/autoland/rev/4abca56fc850
part 3 - Have BrowserFragment handle restoring the layout after find in page ends r=android-reviewers,tchoh

Comment 10

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/8bbfc443032f
https://hg.mozilla.org/mozilla-central/rev/968b90009ba4
https://hg.mozilla.org/mozilla-central/rev/4abca56fc850

Comment 11

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:petru, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox131 to wontfix.

For more information, please visit BugBot documentation.

Comment 12

[Petru-Mugurel Lingurar [:petru]]

This depends on many other changes in flux for the navbar.
Would prefer to let the fix ride the trains.

Comment 13

[Delia Pop]

Attachment: Nightly132_0912_QA_FindinPage.mp4

Verified as fixed on the latest Nightly 132.0a1 from 09/12.

• When the find in page bar is active, no toolbars are displayed.
• After returning to fenix while the find in page bar is active, the navigation bar is not displayed.

Tested with the following devices:

• Samsung Galaxy A53 5G (Android 14)
• Xiaomi 12 Pro (Android 13)
• LG G7 fit (Android 9)
• Samsung Tab S8 Ultra 5G (Android 14)
• Lenovo Yoga Tab 11 (Android 12)