1908639 - [Toolbar Redesign] PDF has it's bottom clipped

Status: VERIFIED FIXED

(Fenix :: Toolbar, defect, P2)

Description

[Delia Pop]

Attachment: FindInPage_PDF.mp4

Steps to reproduce

1. Open the latest Nightly 130.0a1 with the toolbar redesign enabled.
2. Open a PDF file e.g. https://research.nhm.org/pdfs/10840/10840.pdf
3. Tap the 3-dot menu button from the Navigation bar, and tap 'Find in Page'.
4. Enter a word to search (that exists in more than one place).
5. Tap the up and down buttons or tap anywhere on the screen to dismiss the keyboard.
6. Observe the find in page text bar.

Expected behavior

The Find in page text bar is shown above the keyboard.
The Navigation toolbar and address bar are hidden.

Actual behavior

The Find in page text bar appears under the navigation bar, and cannot be used.
Depending on the address bar position, improper blank spaces appear at the bottom and top of the screen when the Find in page text bar is invoked.

Device information

• Firefox version: Nightly 130.0a1 from 07/18
• Android device model: Google Pixel 8 Pro
• Android OS version: Android 14

Additional information

With the additional space taken by the navigation bar, ticket 1809173 should be further investigated, since the navigation bar is currently not dynamic in PDFs.

Comment 1

[Delia Pop]

Attachment: SS from a Samsung Tab S8 Ultra 5G (Android 14) tablet

Comment 2

[Chris Peterson [:cpeterson]]

I think this bug is the same web page issue as bug 1907751. Instead of closing this bug as a duplicate of bug 1907751, I'll it open so we remember to test the PDF Viewer.

Comment 3

[[:skhan]]

:petru , Does this get fixed by Bug 1908620 ?

Comment 4

[Petru-Mugurel Lingurar [:petru]]

Attachment: PDF being clipped in Firefox release 128.png

Seems like there are two issues here after entering "find in page" mode:

• the PDF does not extend to the bottom of the viewport (screenshot added from 128 release). May have more to do with bug 1908249 but I think this will require a new patch.
• the find in page bar is hidden by the navbar. Do think indeed this issue will get fixed after bug 1908620.

Keeping my NI to remember to check after the above linked tickets get fixed.

Comment 5

[Petru-Mugurel Lingurar [:petru]]

Checked now, seems like one of the above two issues have been solved - the find in page bar is not hidden anymore by the navbar.
But the issue with the pdf not extending to full page is still there.
I'll look into fixing this last issue.

Comment 6

[Petru-Mugurel Lingurar [:petru]]

An interesting detail:

• if find in page is opened in landscape and then the app is rotated to portrait there is no issue - (in landscape or portrait)
• if find in page is opened in portrait and then the app is rotated to landscape the issue is always there

=> Seems like there is a different pdf initialization process in portrait vs landscape.

Comment 7

[Petru-Mugurel Lingurar [:petru]]

Also, the remaining part - the bottom of the pdf being clipped is apparently an old bug - bug 1817810 and the cause is related to us configuring the engine view with space for dynamic toolbar but on pdf there's a bug with the toolbar not being dynamic - bug 1809173.

Comment 8

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1908639 - part 1 - Add a new `isPdf` property to `ContentState` r=#android-reviewers

This will inform whether the current page is a pdf or not.

Comment 9

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1908639 - part 2 - Don't update page viewport if currently viewing a pdf or searching in page r=#android-reviewers

Comment 10

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1908639 - part 3 - Set no clipping by default when applying EngineViewClippingBehavior r=#android-reviewers

This is useful in the scenario of coming back to browsing a 100vh page after finishing
a find in page session.
When using a navbar this is happening by default since in the same scenario the navbar
is reset thus triggering an initial clipping evaluation in the appropriate behavior.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/23917b3525d6
part 1 - Add a new `isPdf` property to `ContentState` r=android-reviewers,matt-tighe
https://hg.mozilla.org/integration/autoland/rev/bfc966c85cdf
part 2 - Don't update page viewport if currently viewing a pdf or searching in page r=android-reviewers,skhan
https://hg.mozilla.org/integration/autoland/rev/446f6d4fcb59
part 3 - Set no clipping by default when applying EngineViewClippingBehavior r=android-reviewers,Roger

Comment 12

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/23917b3525d6
https://hg.mozilla.org/mozilla-central/rev/bfc966c85cdf
https://hg.mozilla.org/mozilla-central/rev/446f6d4fcb59

Comment 13

[BugBot [:suhaib / :marco/ :calixte]]

Since nightly and release are affected, beta will likely be affected too.
For more information, please visit BugBot documentation.

Comment 14

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:petru, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox131 to wontfix.

For more information, please visit BugBot documentation.

Comment 15

[Petru-Mugurel Lingurar [:petru]]

This depends on many other changes in flux for the navbar while being an issue possibly from the start.
Would prefer to let the fix ride the trains.

Comment 16

[Delia Pop]

Attachment: FindinPage_PDF_Nightly132.mp4

Verified as fixed on the latest Nightly 132.0a1 from 09/12.
Tested with the following devices:

• Samsung Galaxy A53 5G (Android 14)
• Xiaomi 12 Pro (Android 13)
• Samsung Tab S8 Ultra 5G (Android 14)