1908851 - Can't show PDF attachments in tab

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Richard Marti (:Paenglab)]

Try to click on a PDF attachment to open it in a TB tab. The tab opens but the tab throbber spins endlessly. In console I see:
NS_ERROR_UNEXPECTED: Component returned failure code: 0x8000ffff (NS_ERROR_UNEXPECTED) [nsIPrefBranch.getIntPref] PdfStreamConverter.sys.mjs:385

In the URL bar I see now
imap://[e-mail]:993/fetch%3EUID%3E/Sent%3E95?part=1.2&filename=VHD-Schmitten.pdf&type=application/pdf
with a working TB I see
mailbox:///C:/Users/Richi/AppData/Roaming/thunderbird/Profiles/159577rw.Beta/Mail/Local%20Folders-1/Inbox?number=4&part=1.2&filename=Test.pdf&type=application/pdf

Comment 1

[Magnus Melin [:mkmelin]]

We're missing browser.uidensity

Comment 2

[Magnus Melin [:mkmelin]]

Attachment: Bug 1908851 - Use default value for browser.uidensity. r=#pdfjs-reviewers

browser.uidensity is only set in firefox.js

Comment 3

[Richard Marti (:Paenglab)]

Attachment: Bug 1908851 - Use default value for browser.uidensity. r=#pdfjs-reviewers

Comment 6

[Rob Wu [:robwu]]

The regressing patch landed in 130: https://hg.mozilla.org/mozilla-central/rev/d98e5190542e
Not sure why this bug says that Thunderbird 129 is affected.

FYI: today we just bumped m-c from 130 to 131, so unless there is a kind of "uplift" to Thunderbird 130, TB130 will be permanently affected by this.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4aab58b0468b
Use default value for browser.uidensity. r=pdfjs-reviewers,robwu

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/4aab58b0468b

Comment 9

[Magnus Melin [:mkmelin]]

Thanks Richard!

Comment 10

[Magnus Melin [:mkmelin]]

Comment on attachment 9417210 [details]
Bug 1908851 - Use default value for browser.uidensity. r=#pdfjs-reviewers

Beta/Release Uplift Approval Request

• User impact if declined: Thunderbird users can't open pdfs with internal pdf viewer
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Only adding a default value for a pref that non-firefox apps do not have.
• String changes made/needed: none
• Is Android affected?: No

Comment 15

[Pascal Chevrel:pascalc]

Comment on attachment 9417210 [details]
Bug 1908851 - Use default value for browser.uidensity. r=#pdfjs-reviewers

Approved for 130 beta 5, thanks.

Comment 16

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/ac782ec80278