1910203 - Update all-tabs button icon so we can move the button into the nav bar when vertical tabs are enabled

Status: RESOLVED FIXED

(Firefox :: Theme, defect, P2)

Description

[Sam Foster [:sfoster] (he/him)]

Normally the 'alltabs-button' is positioned next to the tabs in the horizontal tabstrip toolbar, so the down-facing arrow icon makes sense in context. But when we move it to another toolbar like the nav-bar, it loses that context and doesn't really communicate what it does any more, and could use a better icon.

Comment 1

[Sarah Clements [:sclements]]

It's probably worth asking UX whether its worth moving this tool at all, since the list view is duplicating what vertical tabs does. But either way I think we can treat this as a lower priority.

Comment 2

[Sören Hentzschel]

Another consideration: If you want to move the button and replace the icon, it might be good to replace the icon for both the vertical and horizontal tabs configuration, so that different icons do not have to be described in the support depending on the user configuration.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:sclements, could you have a look please?

For more information, please visit BugBot documentation.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:sclements, could you have a look please?

For more information, please visit BugBot documentation.

Comment 5

[Dão Gottwald [:dao]]

(In reply to Sarah Clements [:sclements] from comment #1)

It's probably worth asking UX whether its worth moving this tool at all, since the list view is duplicating what vertical tabs does.

From my conversations with Ania, the plan is still to move it, and https://phabricator.services.mozilla.com/D217161 does so. Are you still considering other options at this point?

But either way I think we can treat this as a lower priority.

Putting on my tabbrowser and theme owner hats, I disagree. The current dropdown icon only makes sense when it's next to the potentially-overflowing items (i.e. tabs). Without that context we absolutely need a new icon here. Tab groups folks discussed this with Ania last week as well (because the still-current plan is to allow users to retrieve saved groups from this popup, so we sort of depend on the icon making sense).

Comment 7

[Sarah Clements [:sclements]]

(In reply to Dão Gottwald [:dao] from comment #5)

(In reply to Sarah Clements [:sclements] from comment #1)

It's probably worth asking UX whether its worth moving this tool at all, since the list view is duplicating what vertical tabs does.

From my conversations with Ania, the plan is still to move it, and https://phabricator.services.mozilla.com/D217161 does so. Are you still considering other options at this point?

What was discussed with addons folks during mozweek is we would move it as an interim solution and then in the future look to removing it for vertical tabs mode, but whatever the UX solution for hidden tabs ends up being would need a conversations with Security team, as we want to prevent malicious applications from hiding tabs.

I don't know if there has been further discussion with tab groups team about this though, has there?

But either way I think we can treat this as a lower priority.

Putting on my tabbrowser and theme owner hats, I disagree. The current dropdown icon only makes sense when it's next to the potentially-overflowing items (i.e. tabs). Without that context we absolutely need a new icon here. Tab groups folks discussed this with Ania last week as well (because the still-current plan is to allow users to retrieve saved groups from this popup, so we sort of depend on the icon making sense).

Ok, I wasn't in that discussion so I'm missing some context and what was agreed but it sounds like this change might make more sense to be tied together with any tab groups work. I could see this actually being very confusing to users if they switch to vertical tabs and the button both moves to a different location and the icon has also changed completely, meaning what they previously used to identify it as the all-tabs button is gone. I think any interim change like this might require a bit more UX and addon team input in terms of what is done and when.

Comment 8

[Dão Gottwald [:dao]]

(In reply to Sarah Clements [:sclements] from comment #7)

Putting on my tabbrowser and theme owner hats, I disagree. The current dropdown icon only makes sense when it's next to the potentially-overflowing items (i.e. tabs). Without that context we absolutely need a new icon here. Tab groups folks discussed this with Ania last week as well (because the still-current plan is to allow users to retrieve saved groups from this popup, so we sort of depend on the icon making sense).

Ok, I wasn't in that discussion so I'm missing some context and what was agreed but it sounds like this change might make more sense to be tied together with any tab groups work.

It's directly tied to bug 1899346 so I think this needs to be considered part of that work. We need this icon to make sense when moved to the navbar, with or without tab groups.

I could see this actually being very confusing to users if they switch to vertical tabs and the button both moves to a different location and the icon has also changed completely, meaning what they previously used to identify it as the all-tabs button is gone.

Probably makes sense to update the icon for both horizontal and vertical modes.

Comment 9

[Sarah Clements [:sclements]]

I discussed this with Ania today and we won't be making an icon change right now.

Comment 10

[Sam Foster [:sfoster] (he/him)]

[Tracking Requested - why for this release]: We should get this fixed before we hit broad release. 131 will be a experiment and its not-blocking for that release.

Need-infoing myself to add the tracking flag next week when we roll over to the next cycle

Comment 11

[Sam Foster [:sfoster] (he/him)]

Removing tracking flag - there's an ongoing discussion about when and how we need to address this, but it will likely be post 132.

Comment 12

[Dão Gottwald [:dao]]

Attachment: Bug 1910203 - Update all-tabs button icon so we can move the button into the nav bar when vertical tabs are enabled. r=mconley!,rpl!

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c3d176da23af
Update all-tabs button icon so we can move the button into the nav bar when vertical tabs are enabled. r=mconley,rpl,tabbrowser-reviewers

Comment 14

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/c3d176da23af

Comment 15

[Dão Gottwald [:dao]]

Comment on attachment 9421626 [details]
Bug 1910203 - Update all-tabs button icon so we can move the button into the nav bar when vertical tabs are enabled. r=mconley!,rpl!

Beta/Release Uplift Approval Request

• User impact if declined: Bug 1899346 wants to conditionally move this button to the navigation toolbar, where the old down-arrow icon lacks the context of being right next to tabs. The sidebar team would like to ship this icon change in 131, ahead of the experiment planned for 132.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It's a fairly straightforward icon swap, although the new one unfortunately is 2020px rather than 1616px, so I had to adjust some CSS to deal with that. Other than that, the usual caveats for UI changes apply; some people might hate the new icon, but so far I haven't seen complaints.
• String changes made/needed:
• Is Android affected?: No

Comment 16

[Dianna Smith [:diannaS]]

Comment on attachment 9421626 [details]
Bug 1910203 - Update all-tabs button icon so we can move the button into the nav bar when vertical tabs are enabled. r=mconley!,rpl!

Approved for 131.0b6

Comment 17

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/6025fa7145d8