1916622 - Remove the browser.tabs.tabmanager.enabled pref

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, task)

Description

[Dão Gottwald [:dao]]

Given bug 1899346, we should simplify the logic around the all-tabs button by removing support for flipping browser.tabs.tabmanager.enabled.

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 1916622 - Remove the browser.tabs.tabmanager.enabled pref. r=#tabbrowser

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d930497a6fd8
Remove the browser.tabs.tabmanager.enabled pref. r=tabbrowser-reviewers,extension-reviewers,desktop-theme-reviewers,emilio,robwu,dwalker

Comment 3

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/d930497a6fd8

Comment 4

[Sarah Clements [:sclements]]

I think we wanted to get this uplifted to 131 beta, per the discussion on friday?

Comment 5

[Dão Gottwald [:dao]]

Comment on attachment 9422476 [details]
Bug 1916622 - Remove the browser.tabs.tabmanager.enabled pref. r=#tabbrowser

Beta/Release Uplift Approval Request

• User impact if declined: Bug 1899346 wants to conditionally move this button to the navigation toolbar, where the "only show when overflowing" logic (that we had for browser.tabs.tabmanager.enabled = false) wouldn't work, therefore it seems best to remove this old pref. Advanced users can still use userChrome.css to hide the button. The sidebar team would like to ship this in 131, ahead of the experiment planned for 132.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): There's likely a small but opinionated minority of users who had set this pref to false.
• String changes made/needed:
• Is Android affected?: No

Comment 6

[Dianna Smith [:diannaS]]

Comment on attachment 9422476 [details]
Bug 1916622 - Remove the browser.tabs.tabmanager.enabled pref. r=#tabbrowser

Approved for 131.0b5

Comment 7

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/955083d62f59