1911198 - Pull to refresh it no longer works properly on any wikipedia.org page

Status: VERIFIED FIXED

(Fenix :: Browser Engine, defect, P1)

Description

[eclaudiu64]

Attachment: mobizen_20240802_005019.mp4

User Agent: Mozilla/5.0 (Android 11; Mobile; rv:130.0) Gecko/130.0 Firefox/130.0

Steps to reproduce:

Pull to refresh no longer works correctly on all sites since the new toolbar was enabled by default. For example, we access the website: wikipedia.ckm and it can be seen that with the Pull to refresh setting activated, it no longer triggers the refresh.

Actual results:

Pull to refresh no longer works properly.

Expected results:

Pull to refresh to trigger immediately on every touch.

Comment 1

[eclaudiu64]

Another error when activating the new toolbar.

Comment 2

[Chris Peterson [:cpeterson]]

Thanks. I can reproduce this bug on any wikipedia.org page when using the new toolbar.

Comment 3

[Roger Yang [:royang]]

Looks like something recently broke pull to refresh. I can reproduce the issue on Nightly with or without Navigation Bar. However, in Beta, I can't reproduce the issue even though the same code is there (Navigation bar is not enabled but the same code is running)

Something recently broken this in Nightly. I'll find the regressor.

Comment 4

[Roger Yang [:royang]]

Found the regression was from Bug 1897567. Unrelated to navigation bar changes.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

:hiro, since you are the author of the regressor, bug 1897567, could you take a look?

For more information, please visit BugBot documentation.

Comment 6

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1911198 - Allow touch event interception in the case the ACTION_DOWN event result is INPUT_HANDLED. r?tthibaud

Given that there's no touch event listener, in the case of ACTION_DOWN event
Gecko responds without waiting subsequent ACTION_MOVE events, thus we can allow
touch event intersection if the result is not INPUT_HANDLED_CONTENT.

Comment 9

[Liz Henry (:lizzard) (relman/hg->git project)]

Hiro, is still just still waiting for review? It is not too late to potentially land this and uplift a patch to 130 beta, if you think it safe.

While this has an S3 severity, the fact that it has a couple of duplicate bug reports from Nightly and beta, from community contributors rather than QA, makes me think we should treat it more seriously before it goes to release.

Comment 10

[Hiroyuki Ikezoe (:hiro)]

(welcome back, Liz)

Yeah, I am still waiting for review and I agree that it would be nice to be fixed in beta.

CCing Titouan.

Comment 11

[Titouan Thibaud [:titouan]]

I just approved the patch, it seems good to me. Thanks for CCing me, and for putting the patch!

Comment 12

[Ryan VanderMeulen [:RyanVM]]

We're building our final beta of the cycle tomorrow, so please land and request Beta approval ASAP.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/39b31b51f837
Allow touch event interception in the case the ACTION_DOWN event result is INPUT_HANDLED. r=tthibaud,android-reviewers

Comment 14

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 9417651 [details]
Bug 1911198 - Allow touch event interception in the case the ACTION_DOWN event result is INPUT_HANDLED. r?tthibaud

Beta/Release Uplift Approval Request

• User impact if declined: pull-to-refresh is very hard to trigger on some sites
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Load wikipedia.org and try to scroll up to see whether pull-to-refresh is triggered
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This change is one line, it's used to tell whether pull-to-refresh is triggered or not in a certain condition, nothing more and nothing less.
• String changes made/needed: None
• Is Android affected?: Yes

Comment 15

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9417651 [details]
Bug 1911198 - Allow touch event interception in the case the ACTION_DOWN event result is INPUT_HANDLED. r?tthibaud

Looks like the approval flag somehow didn't get set there.

Comment 16

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/39b31b51f837

Comment 17

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9417651 [details]
Bug 1911198 - Allow touch event interception in the case the ACTION_DOWN event result is INPUT_HANDLED. r?tthibaud

Approved for 130.0b9.

Comment 18

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/51dcbed55368

Comment 19

[Adina Petridean QA [:apetridean]]

Verified as fixed on the latest Nightly 131.0a1 from 26.08.2024 and Firefox 130.0b9 with Lenovo TB X606X (Android 10) and Samsung Galaxy S23 Ultra (Android 14).